Review main Merged

77724[BUGFIX] Include hidden task groups in select

Jochen Roth CR +2 V +2 Easy +5 −3 updated 02/09/23, 13:58

Commit message

Hidden task groups are not shown in the dropdown
when editing a task. When a task was saved the
selected (hidden) group is lost.

This has been fixed by extending the query to
include hidden groups.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Josef Glatz +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Josef Glatz +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Jochen Roth uploaded patch set 1 02/06/23, 19:50

  2. core-ci voted on patch set 1 V +1 02/06/23, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37214

  3. Georg Ringer commented on patch set 1 CR +1 02/06/23, 22:53

    IMO also valid for 11, correct?
  4. Josef Glatz voted on patch set 1 V +1 CR +1 02/07/23, 05:04

  5. Jochen Roth uploaded patch set 2 CR +1 V +1 02/07/23, 10:16

  6. Jochen Roth commented on patch set 1 02/07/23, 10:18

    Reply

    Yep, you're right. Added 11.5 Thanks
  7. core-ci voted on patch set 2 V +1 02/07/23, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37269

  8. Jochen Roth updated the commit message in patch set 3 V +1 02/07/23, 10:46

  9. core-ci voted on patch set 3 V +1 02/07/23, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37274

  10. Josef Glatz voted on patch set 3 V +1 CR +1 02/09/23, 13:43

  11. Christian Kuhn voted on patch set 3 V +2 CR +2 02/09/23, 13:58

  12. Christian Kuhn merged patch set 4 02/09/23, 13:58