77725[TASK] Unify spelling of page TSconfig
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 54
- typo3/sysext/backend/Classes/Backend/Shortcut/ShortcutRepository.php+1 −1
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigActiveController.php+6 −6
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigIncludesController.php6+10 −10
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigRecordsOverviewController.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+4 −4
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseRowInitializeNew.php+3 −3
- typo3/sysext/backend/Classes/Form/FormDataProvider/PageTsConfig.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/PageTsConfigMerged.php2+2 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaColumnsProcessFieldLabels.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaFlexProcess.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaRadioItems.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/UserTsConfig.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataCompiler.php+3 −3
- typo3/sysext/backend/Classes/LinkHandler/LinkHandlerInterface.php+1 −1
- typo3/sysext/backend/Classes/LinkHandler/RecordLinkHandler.php+2 −2
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+5 −5
- typo3/sysext/backend/Classes/View/BackendLayout/PageTsBackendLayoutDataProvider.php+3 −3
- typo3/sysext/backend/Resources/Private/Language/locallang_pagetsconfig.xlf+12 −12
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+11 −11
Show 34 more files
- typo3/sysext/core/Classes/Configuration/Event/ModifyLoadedPageTsConfigEvent.php+1 −1
- typo3/sysext/core/Classes/Configuration/Loader/PageTsConfigLoader.php+1 −1
- typo3/sysext/core/Classes/Configuration/Parser/PageTsConfigParser.php+3 −3
- typo3/sysext/core/Classes/Configuration/PageTsConfig.php+5 −5
- typo3/sysext/core/Classes/Configuration/Richtext.php+2 −2
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+2 −2
- typo3/sysext/core/Classes/DataHandling/PagePermissionAssembler.php+3 −3
- typo3/sysext/core/Classes/ExpressionLanguage/FunctionsProvider/DefaultFunctionsProvider.php+1 −1
- typo3/sysext/core/Classes/ExpressionLanguage/DeprecatingRequestWrapper.php+11 −11
- typo3/sysext/core/Classes/Html/RteHtmlParser.php+1 −1
- typo3/sysext/core/Classes/Localization/LanguageService.php+1 −1
- typo3/sysext/core/Classes/Resource/Service/MagicImageService.php+1 −1
- typo3/sysext/core/Classes/Site/Entity/NullSite.php+1 −1
- typo3/sysext/core/Classes/TypoScript/AST/CommentAwareAstBuilder.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Event/ModifyLoadedPageTsConfigEvent.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeCommentAwareAstBuilderVisitor.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeConditionAggregatorVisitor.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeConditionEnforcerVisitor.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeNodeFinderVisitor.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeSourceAggregatorVisitor.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeSyntaxScannerVisitor.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/TsConfigTreeBuilder.php+1 −1
- typo3/sysext/core/Classes/TypoScript/PageTsConfig.php+1 −1
- typo3/sysext/core/Classes/TypoScript/PageTsConfigFactory.php+5 −5
- typo3/sysext/core/Classes/TypoScript/UserTsConfig.php+1 −1
- typo3/sysext/core/Classes/TypoScript/UserTsConfigFactory.php+5 −5
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+3 −3
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −1
- typo3/sysext/core/Documentation/Changelog/Howto.rst+1 −1
- typo3/sysext/impexp/Classes/Controller/ExportController.php+1 −1
- typo3/sysext/impexp/Classes/Controller/ImportController.php+1 −1
- typo3/sysext/impexp/Documentation/Security/Index.rst+1 −1
- typo3/sysext/lowlevel/Documentation/Configuration/TSconfig.rst+1 −1
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+2 −2
Review log 2941
Show 916 earlier messages
-
Jasmina Ließmann uploaded patch set 1 02/06/23, 20:02
-
core-ci voted on patch set 1 V +1 02/06/23, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37215
-
Jasmina Ließmann uploaded patch set 2
V +102/06/23, 20:10 -
Jasmina Ließmann updated the commit message in patch set 3 02/06/23, 20:11
-
core-ci voted on patch set 3 V +1 02/06/23, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37218
-
core-ci voted on patch set 2 V +1 02/06/23, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37217
-
Christoph Lehmann commented on patch set 3 02/06/23, 20:25
PageTsConfigIncludesController.php:201user TSconfigPageTsConfigIncludesController.php:278user TSconfigPageTsConfigMerged.php:27page TSconfig -
Jasmina Ließmann uploaded patch set 4
V +102/06/23, 20:42 -
Jasmina Ließmann uploaded patch set 5 02/06/23, 20:46
-
core-ci voted on patch set 4 V +1 02/06/23, 20:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37220
-
core-ci voted on patch set 5 V +1 02/06/23, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37221
-
Jasmina Ließmann uploaded patch set 6
V +102/06/23, 20:56 -
Jasmina Ließmann commented on patch set 6 02/06/23, 20:57
PageTsConfigIncludesController.php:123ReplyDonePageTsConfigIncludesController.php:201ReplyDonePageTsConfigIncludesController.php:278ReplyDonePageTsConfigMerged.php:27ReplyDone -
core-ci voted on patch set 6 V +1 02/06/23, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37223
-
Anja Leichsenring uploaded patch set 7
V +102/16/23, 18:25 -
core-ci voted on patch set 7 V +1 02/16/23, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37812
-
Anja Leichsenring uploaded patch set 8
V +102/16/23, 18:33 -
Anja Leichsenring commented on patch set 8 V +1 CR +1 02/16/23, 18:37
merge conflict solved in typo3/sysext/backend/Classes/View/BackendLayout/PageTsBackendLayoutDataProvider.php. Please verify, that I did it correctly? -
core-ci voted on patch set 8 V +1 02/16/23, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37813
-
Jasmina Ließmann uploaded patch set 9
CR +1V +102/17/23, 17:46 -
core-ci voted on patch set 9 V +1 02/17/23, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37852
-
Jasmina Ließmann commented on patch set 9 02/17/23, 17:58
Reply
Thanks, that's fine. I made two more adjustments in that file. -
Jasmina Ließmann uploaded patch set 10
V +103/02/23, 19:41 -
core-ci voted on patch set 10 V +1 03/02/23, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38326
-
Lina Wolf commented on patch set 10 03/03/23, 07:17
We collect rules on how to spell specific terms on this page: https://docs.typo3.org/m/typo3/docs-how-to-document/main/en-us/GeneralConventions/Glossary.html -
Jasmina Ließmann updated the commit message in patch set 11
V +103/03/23, 07:24 -
Jasmina Ließmann commented on patch set 11 03/03/23, 07:26
Reply
Added it to the commit message. -
Lina Wolf commented on patch set 11 V +1 CR +1 03/03/23, 07:30
Almost all changes are in comments. The changes in Strings and localization files also look good to me. There is nothing to test -
core-ci voted on patch set 11 V +1 03/03/23, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38338
-
Chris Müller voted on patch set 11 V +1 CR +1 03/03/23, 09:14
-
Benni Mack commented on patch set 11 03/03/23, 13:16
Hey, as much as I'm for unification, are we 100% sure on the spelling? searching for "UserTsConfig" finds more + better search terms than "user TSconfig". I also think the proposal was the other way around, see https://decisions.typo3.org/t/clarification-of-term-typoscript/560/3 -
Jasmina Ließmann commented on patch set 11 03/03/23, 15:36
Reply
I'm open to update the patch, as long as I have a final wording to go with. The main goal for me is to unify the different spellings that currently exist. As far as I can see the voting/decision thread hasn't come to a final conclusion on the spelling of this term. Over the years I've gotten used to the spelling "TSconfig" so personally I tend to keep the 'TS' in uppercase if we want the term to remain two-word. If it should be just one word instead of two, then I would take your suggestion "UserTsConfig" respectively "PageTsConfig". -
Chris Müller commented on patch set 11 03/16/23, 08:08
Reply
We use "page TSconfig" and "user TSconfig" throughout the documentation, for example: https://docs.typo3.org/m/typo3/reference-tsconfig/11.5/en-us/PageTsconfig/Index.html -
Jasmina Ließmann commented on patch set 11 03/16/23, 09:25
Reply
So maybe we'll stick with this version for now and change it later if needed? -
Benni Mack commented on patch set 11 03/16/23, 10:02
Reply
🤐 -
Jasmina Ließmann uploaded patch set 12
CR +1V +103/27/23, 19:13 -
Christian Kuhn commented on patch set 12 03/27/23, 19:26
summary: 95% of the patch are comment changes, and only the page TSconfig module gets some additional .xlf changes. fine with me. -
core-ci voted on patch set 12 V +1 03/27/23, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39720
-
Christian Kuhn voted on patch set 12 V +1 CR +1 03/27/23, 19:34
-
Stefan Bürk voted on patch set 12 V +2 CR +2 03/27/23, 19:40
-
Stefan Bürk merged patch set 13 03/27/23, 19:40
PageTsConfigIncludesController.php:123