Review main Merged

77725[TASK] Unify spelling of page TSconfig

Jasmina Ließmann CR +2 V +2 Hard +135 −135 updated 03/27/23, 19:40

Commit message

Some specific TYPO3 terms have a special spelling. Therefore
update the spelling from "PageTsConfig" to "page TSconfig"
and "UserTsConfig" to "user TSconfig" as once defined here:
https://docs.typo3.org/m/typo3/docs-how-to-document/main/en-us/GeneralConventions/Glossary.html

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 54

Show 34 more files

Review log 2941

Show 916 earlier messages
  1. Jasmina Ließmann uploaded patch set 1 02/06/23, 20:02

  2. core-ci voted on patch set 1 V +1 02/06/23, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37215

  3. Jasmina Ließmann uploaded patch set 2 V +1 02/06/23, 20:10

  4. Jasmina Ließmann updated the commit message in patch set 3 02/06/23, 20:11

  5. core-ci voted on patch set 3 V +1 02/06/23, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37218

  6. core-ci voted on patch set 2 V +1 02/06/23, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37217

  7. Christoph Lehmann commented on patch set 3 02/06/23, 20:25

    PageTsConfigIncludesController.php:123

    user TSconfig

    PageTsConfigIncludesController.php:201

    user TSconfig

    PageTsConfigIncludesController.php:278

    user TSconfig

    PageTsConfigMerged.php:27

    page TSconfig
  8. Jasmina Ließmann uploaded patch set 4 V +1 02/06/23, 20:42

  9. Jasmina Ließmann uploaded patch set 5 02/06/23, 20:46

  10. core-ci voted on patch set 4 V +1 02/06/23, 20:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37220

  11. core-ci voted on patch set 5 V +1 02/06/23, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37221

  12. Jasmina Ließmann uploaded patch set 6 V +1 02/06/23, 20:56

  13. Jasmina Ließmann commented on patch set 6 02/06/23, 20:57

    PageTsConfigIncludesController.php:123 Reply

    Done

    PageTsConfigIncludesController.php:201 Reply

    Done

    PageTsConfigIncludesController.php:278 Reply

    Done

    PageTsConfigMerged.php:27 Reply

    Done
  14. core-ci voted on patch set 6 V +1 02/06/23, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37223

  15. Anja Leichsenring uploaded patch set 7 V +1 02/16/23, 18:25

  16. core-ci voted on patch set 7 V +1 02/16/23, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37812

  1. Anja Leichsenring uploaded patch set 8 V +1 02/16/23, 18:33

  2. Anja Leichsenring commented on patch set 8 V +1 CR +1 02/16/23, 18:37

    merge conflict solved in typo3/sysext/backend/Classes/View/BackendLayout/PageTsBackendLayoutDataProvider.php. Please verify, that I did it correctly?
  3. core-ci voted on patch set 8 V +1 02/16/23, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37813

  4. Jasmina Ließmann uploaded patch set 9 CR +1 V +1 02/17/23, 17:46

  5. core-ci voted on patch set 9 V +1 02/17/23, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37852

  6. Jasmina Ließmann commented on patch set 9 02/17/23, 17:58

    Reply

    Thanks, that's fine. I made two more adjustments in that file.
  7. Jasmina Ließmann uploaded patch set 10 V +1 03/02/23, 19:41

  8. core-ci voted on patch set 10 V +1 03/02/23, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38326

  9. Lina Wolf commented on patch set 10 03/03/23, 07:17

  10. Jasmina Ließmann updated the commit message in patch set 11 V +1 03/03/23, 07:24

  11. Jasmina Ließmann commented on patch set 11 03/03/23, 07:26

    Reply

    Added it to the commit message.
  12. Lina Wolf commented on patch set 11 V +1 CR +1 03/03/23, 07:30

    Almost all changes are in comments. The changes in Strings and localization files also look good to me. There is nothing to test
  13. core-ci voted on patch set 11 V +1 03/03/23, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38338

  14. Chris Müller voted on patch set 11 V +1 CR +1 03/03/23, 09:14

  15. Benni Mack commented on patch set 11 03/03/23, 13:16

    Hey, as much as I'm for unification, are we 100% sure on the spelling? searching for "UserTsConfig" finds more + better search terms than "user TSconfig". I also think the proposal was the other way around, see https://decisions.typo3.org/t/clarification-of-term-typoscript/560/3
  16. Jasmina Ließmann commented on patch set 11 03/03/23, 15:36

    Reply

    I'm open to update the patch, as long as I have a final wording to go with. The main goal for me is to unify the different spellings that currently exist. As far as I can see the voting/decision thread hasn't come to a final conclusion on the spelling of this term. Over the years I've gotten used to the spelling "TSconfig" so personally I tend to keep the 'TS' in uppercase if we want the term to remain two-word. If it should be just one word instead of two, then I would take your suggestion "UserTsConfig" respectively "PageTsConfig".
  17. Chris Müller commented on patch set 11 03/16/23, 08:08

    Reply

    We use "page TSconfig" and "user TSconfig" throughout the documentation, for example: https://docs.typo3.org/m/typo3/reference-tsconfig/11.5/en-us/PageTsconfig/Index.html
  18. Jasmina Ließmann commented on patch set 11 03/16/23, 09:25

    Reply

    So maybe we'll stick with this version for now and change it later if needed?
  19. Benni Mack commented on patch set 11 03/16/23, 10:02

    Reply

    🤐
  20. Jasmina Ließmann uploaded patch set 12 CR +1 V +1 03/27/23, 19:13

  21. Christian Kuhn commented on patch set 12 03/27/23, 19:26

    summary: 95% of the patch are comment changes, and only the page TSconfig module gets some additional .xlf changes. fine with me.
  22. core-ci voted on patch set 12 V +1 03/27/23, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39720

  23. Christian Kuhn voted on patch set 12 V +1 CR +1 03/27/23, 19:34

  24. Stefan Bürk voted on patch set 12 V +2 CR +2 03/27/23, 19:40

  25. Stefan Bürk merged patch set 13 03/27/23, 19:40