77726[TASK] Remove "typo3Language" configuration option
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 32
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+10 −2
- typo3/sysext/backend/Classes/Controller/SiteInlineAjaxController.php+0 −8
- typo3/sysext/backend/Classes/Form/FormDataProvider/SiteTcaSelectItems.php+0 −15
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSiteLanguage.php+0 −8
- typo3/sysext/backend/Configuration/SiteConfiguration/site_language.php+1 −12
- typo3/sysext/backend/Resources/Private/Language/locallang_siteconfiguration_tca.xlf+0 −3
- typo3/sysext/backend/Resources/Private/Language/siteconfiguration_fieldinformation.xlf+0 −3
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaSelectItemsTest.php+0 −3
- typo3/sysext/core/Classes/Configuration/SiteConfiguration.php+0 −1
- typo3/sysext/core/Classes/Localization/Locale.php+9 −0
- typo3/sysext/core/Classes/Site/Entity/Site.php+0 −1
- typo3/sysext/core/Classes/Site/Entity/SiteLanguage.php+21 −5
- typo3/sysext/core/Documentation/Changelog/12.3/Deprecation-99882-SiteLanguageTypo3LanguageSetting.rstnew+65 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Hooks/PagesTsConfigGuardTest.php+0 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Slug/SlugHelperTest.php+1 −4
- typo3/sysext/core/Tests/Functional/DataHandling/AbstractDataHandlerActionTestCase.php+0 −3
- typo3/sysext/core/Tests/Functional/DataScenarios/AbstractDataHandlerActionTestCase.php+0 −3
- typo3/sysext/core/Tests/Functional/SiteHandling/SiteBasedTestTrait.php+0 −2
- typo3/sysext/core/Tests/Unit/Configuration/Fixtures/SiteConfigs/config1.yaml+0 −2
- typo3/sysext/core/Tests/Unit/Configuration/Fixtures/SiteConfigs/config1_expected.yaml+0 −1
Show 12 more files
- typo3/sysext/core/Tests/Unit/Configuration/Fixtures/SiteConfigs/config2.yaml+0 −1
- typo3/sysext/core/Tests/Unit/Configuration/Fixtures/SiteConfigs/config2_expected.yaml+0 −2
- typo3/sysext/core/Tests/Unit/Configuration/SiteConfigurationTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Localization/LocaleTest.php+6 −0
- typo3/sysext/core/Tests/Unit/Site/Entity/SiteLanguageTest.php+53 −1
- typo3/sysext/form/Classes/Controller/FormEditorController.php+0 −1
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+0 −1
- typo3/sysext/frontend/Tests/Functional/Rendering/TitleTagRenderingTest.php+0 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+6 −8
- typo3/sysext/frontend/Tests/Unit/Plugin/AbstractPluginTest.php+1 −2
- typo3/sysext/install/Tests/Functional/Updates/MigrateSiteSettingsConfigUpdateTest.php+0 −2
- typo3/sysext/redirects/Tests/Functional/Service/SlugServiceTest.php+1 −4
Review log 1217
-
Benni Mack uploaded patch set 1 02/06/23, 20:09
-
core-ci voted on patch set 1 V -1 02/06/23, 20:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37216
-
Benni Mack uploaded patch set 2
V -102/07/23, 07:28 -
core-ci voted on patch set 2 V +1 02/07/23, 07:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37249
-
Benni Mack uploaded patch set 3
V +102/08/23, 16:29 -
Benni Mack updated the commit message in patch set 4 02/08/23, 16:32
-
core-ci voted on patch set 3 V +1 02/08/23, 16:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37388
-
core-ci voted on patch set 4 V +1 02/08/23, 16:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37389
-
Benni Mack uploaded patch set 5 02/08/23, 16:46
Copied Votes: * Verified+1 (copy condition: "changekind:NO_CHANGE") -
core-ci voted on patch set 5 V +1 02/08/23, 17:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37390
-
Georg Ringer commented on patch set 5 V +1 CR +1 02/09/23, 08:19
would be in favor of a feature rst but fine that way as well -
Benni Mack commented on patch set 5 02/09/23, 11:12
Reply
Feature.RST is planned when the last change in the module is done (where we only have language + country selection) -
Andreas Kienast commented on patch set 5 V +1 CR +1 02/09/23, 12:16
Whoever is responsible for https://json.schemastore.org/typo3.json (used in phpstorm as schema validation) should mark `typo3Language` as optional / obsolete. -
Georg Ringer commented on patch set 5 02/09/23, 12:53
Reply
it's me ;) -
Benni Mack voted on patch set 5 V +2 CR +2 02/09/23, 13:09
-
Benni Mack merged patch set 6 02/09/23, 13:09
-
Benni Mack commented on patch set 6 02/09/23, 13:10
thank you for the reviews. Step 1 is done, I will provide continued patches until Step 5 )