Review main Merged

77726[TASK] Remove "typo3Language" configuration option

Benni Mack CR +2 V +2 Hard +174 −101 updated 02/09/23, 13:10

Commit message

This change removes the default configuration
of "typo3Language" in the site language configuration.

This served the language key used for rendering
translated labels from XLF files.

The option is removed from the UI, and if the
"typo3Language" is not set in the language configuration,
the language is resolved from the locale.

In addition, certain values regarding system locales
in POSIX format (values such as "C" or "POSIX") are
now handled in the Locale class as well.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 32

Show 12 more files

Review log 1217

  1. Benni Mack uploaded patch set 1 02/06/23, 20:09

  2. core-ci voted on patch set 1 V -1 02/06/23, 20:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37216

  3. Benni Mack uploaded patch set 2 V -1 02/07/23, 07:28

  4. core-ci voted on patch set 2 V +1 02/07/23, 07:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37249

  5. Benni Mack uploaded patch set 3 V +1 02/08/23, 16:29

  6. Benni Mack updated the commit message in patch set 4 02/08/23, 16:32

  7. core-ci voted on patch set 3 V +1 02/08/23, 16:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37388

  8. core-ci voted on patch set 4 V +1 02/08/23, 16:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37389

  9. Benni Mack uploaded patch set 5 02/08/23, 16:46

    Copied Votes: * Verified+1 (copy condition: "changekind:NO_CHANGE")
  10. core-ci voted on patch set 5 V +1 02/08/23, 17:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37390

  11. Georg Ringer commented on patch set 5 V +1 CR +1 02/09/23, 08:19

    would be in favor of a feature rst but fine that way as well
  12. Benni Mack commented on patch set 5 02/09/23, 11:12

    Reply

    Feature.RST is planned when the last change in the module is done (where we only have language + country selection)
  13. Andreas Kienast commented on patch set 5 V +1 CR +1 02/09/23, 12:16

    Whoever is responsible for https://json.schemastore.org/typo3.json (used in phpstorm as schema validation) should mark `typo3Language` as optional / obsolete.
  14. Georg Ringer commented on patch set 5 02/09/23, 12:53

    Reply

    it's me ;)
  15. Benni Mack voted on patch set 5 V +2 CR +2 02/09/23, 13:09

  16. Benni Mack merged patch set 6 02/09/23, 13:09

  17. Benni Mack commented on patch set 6 02/09/23, 13:10

    thank you for the reviews. Step 1 is done, I will provide continued patches until Step 5 )