Review main Merged

77727[BUGFIX] Prevent disabled page cache access

Christian Kuhn CR +2 V +2 Easy +6 −3 updated 02/06/23, 22:58

Commit message

A broken boolean toggle introduced with #99282
prevents page cache hits in FE under various
conditions.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • Christoph Lehmann +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1622

  1. Christian Kuhn uploaded patch set 1 02/06/23, 20:18

  2. core-ci voted on patch set 1 V -1 02/06/23, 20:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37219

  3. Oliver Hader voted on patch set 1 CR +1 02/06/23, 20:40

  4. Oliver Hader voted on patch set 1 V +1 02/06/23, 20:41

  5. core-ci commented on patch set 1 02/06/23, 20:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37219

  6. Stefan Bürk rebased onto patch set 2 CR +1 V +1 02/06/23, 21:11

  7. Anja Leichsenring commented on patch set 2 V +1 CR +1 02/06/23, 21:12

    nightly in progress to test it all
  8. Stefan Bürk commented on patch set 2 02/06/23, 21:13

  9. core-ci voted on patch set 2 V +1 02/06/23, 21:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37225

  10. Christian Kuhn uploaded patch set 3 CR +1 V +1 02/06/23, 21:26

  11. Christian Kuhn uploaded patch set 4 02/06/23, 21:34

  12. Christian Kuhn voted on patch set 4 CR -1 02/06/23, 21:41

  13. core-ci voted on patch set 4 V +1 02/06/23, 21:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37229

  14. Christian Kuhn uploaded patch set 5 CR -1 V +1 02/06/23, 21:48

  15. core-ci voted on patch set 5 V +1 02/06/23, 21:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37231

  16. Nikita Hovratov voted on patch set 5 V +1 CR +1 02/06/23, 22:00

  17. Stefan Bürk voted on patch set 5 V +1 CR +1 02/06/23, 22:50

  18. Jochen Roth voted on patch set 5 V +1 CR +1 02/06/23, 22:51

  19. Christoph Lehmann voted on patch set 5 CR +1 02/06/23, 22:52

  20. core-ci commented on patch set 5 02/06/23, 22:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37233

  21. Christian Kuhn voted on patch set 5 V +2 CR +2 02/06/23, 22:58

  22. Christian Kuhn merged patch set 6 02/06/23, 22:58