Review main Merged

77751[TASK] Streamline recordlisting appearance

Benjamin Kott CR +2 V +2 Hard +259 −171 updated 02/09/23, 15:48

Commit message

This patch aligns the appearance of the
record list with panels in the backend.

- Align checkboxes for multi record selection properly
- Streamline recordlist header actions
- Streamline first and last child edge padding
- Make typo3-backend-new-content-element-wizard-button
  component immitate button behaviour
- Make typo3-recordlist-record-download-button
  component immitate button behaviour
- Correct action spacing in page module

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 27

Show 7 more files

Review log 1726

Show 1 earlier messages
  1. Benjamin Kott uploaded patch set 1 02/07/23, 11:34

  1. core-ci voted on patch set 1 V -1 02/07/23, 11:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37278

  2. Benjamin Kott uploaded patch set 2 V -1 02/07/23, 12:24

  3. Benjamin Kott updated the commit message in patch set 3 02/07/23, 12:25

  4. core-ci voted on patch set 3 V +1 02/07/23, 12:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37287

  5. core-ci voted on patch set 2 V +1 02/07/23, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37286

  6. Markus Klein voted on patch set 3 CR +1 02/07/23, 13:43

  7. Benjamin Kott uploaded patch set 4 CR +1 V +1 02/07/23, 14:30

  8. core-ci voted on patch set 4 V +1 02/07/23, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37293

  9. Andreas Kienast commented on patch set 4 02/07/23, 15:53

    FileList.php:1257

    but why? I'm not sure whether this will cause issues with CSP.
  10. Benjamin Kott commented on patch set 4 02/07/23, 16:03

    FileList.php:1257 Reply

    it avoids default browser behaviour of links jumping around or refreshing the location bar. by setting the target to # we are suggesting we are targeting an anchor, that we are not doing here. so javascript:; seems to be the best solution for this.
  11. Benjamin Kott uploaded patch set 5 V +1 02/08/23, 12:50

  12. core-ci voted on patch set 5 V +1 02/08/23, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37358

  13. Andreas Kienast commented on patch set 5 02/09/23, 07:56

    FileList.php:1257 Reply

    Done
  14. Benjamin Kott uploaded patch set 6 V +1 02/09/23, 07:57

  15. core-ci voted on patch set 6 V +1 02/09/23, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37427

  16. Benjamin Kott uploaded patch set 7 V +1 02/09/23, 12:24

  17. core-ci voted on patch set 7 V -1 02/09/23, 12:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37443

  18. Andreas Kienast uploaded patch set 8 V -1 02/09/23, 13:30

  19. core-ci voted on patch set 8 V +1 02/09/23, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37458

  20. Andreas Kienast uploaded patch set 9 V +1 02/09/23, 13:49

  21. core-ci voted on patch set 9 V +1 02/09/23, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37463

  22. Andreas Kienast voted on patch set 9 V +1 CR +1 02/09/23, 14:29

  23. Benni Mack voted on patch set 9 V +2 CR +2 02/09/23, 14:35

  24. Benni Mack merged patch set 10 02/09/23, 14:35

  25. Jasmina Ließmann commented on patch set 10 02/09/23, 15:48

    Unresolved

    post -1 from me. Through an earlier patch, the panel header uses a light appearance. The now bigger appeareace of the panel header and the smaller distance between each .recordlist makes it more difficult to get a clear overview overall and to differentiate between groups. Could we add some spacing between them again?