77772[TASK] Add delete action for usergroup list
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/beuser/Resources/Private/Language/locallang.xlf2+4 −1
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/IndexListRow.html2+10 −3
- typo3/sysext/beuser/Resources/Private/Partials/BackendUserGroup/IndexListRow.html4+16 −0
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Groups.html+1 −1
Review log 2130
Show 45 earlier messages
-
Jochen Roth uploaded patch set 1 02/07/23, 11:40
-
core-ci voted on patch set 1 V -1 02/07/23, 12:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37279
-
Josef Glatz commented on patch set 1 V -1 CR -1 02/07/23, 16:24
-
Jochen Roth uploaded patch set 2
CR -1V -102/08/23, 09:50 -
Jochen Roth uploaded patch set 3 02/08/23, 10:05
-
core-ci voted on patch set 2 V -1 02/08/23, 10:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37346
-
core-ci voted on patch set 3 V +1 02/08/23, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37349
-
Jochen Roth uploaded patch set 4
V +102/08/23, 10:41 -
Jochen Roth commented on patch set 4 02/08/23, 10:41
locallang.xlf:171ReplyNow using "backendUserGroup.confirm". If you are still not happy with the naming, let we know which key you prefer. :-) -
core-ci voted on patch set 4 V +1 02/08/23, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37353
-
Josef Glatz commented on patch set 5
V +102/08/23, 13:19Published edit on patch set 4. -
core-ci voted on patch set 5 V +1 02/08/23, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37363
-
Jochen Roth uploaded patch set 6
V +102/08/23, 13:56 -
core-ci voted on patch set 6 V +1 02/08/23, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37371
-
Jochen Roth uploaded patch set 7
V +102/08/23, 14:25 -
core-ci voted on patch set 7 V +1 02/08/23, 14:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37380
-
Christian Kuhn commented on patch set 7 CR -1 02/10/23, 09:40
IndexListRow.html:46this should be a POST request. -
Jochen Roth uploaded patch set 8
CR -1V +102/14/23, 15:34 -
core-ci voted on patch set 8 V +1 02/14/23, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37699
-
Jochen Roth commented on patch set 8 02/14/23, 15:46
IndexListRow.html:46ReplyDone -
Josef Glatz voted on patch set 8 V +1 CR +1 02/14/23, 16:02
-
Oli Bartsch uploaded patch set 9
CR +1V +102/14/23, 16:42 -
Oli Bartsch voted on patch set 9 V +1 CR +1 02/14/23, 16:44
-
core-ci voted on patch set 9 V +1 02/14/23, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37702
-
Christian Kuhn commented on patch set 9 CR -1 02/15/23, 08:31
yay. now with post request :) gimme some time to test. -
Simon Schaufelberger commented on patch set 9 02/15/23, 09:30
IndexListRow.html:70a button with type submit without a form tag around is kinda strange. I would expect that only within a form tag. why not a button with type button?IndexListRow.html:47same here -
Christian Kuhn commented on patch set 9 02/15/23, 09:37
IndexListRow.html:70Replyit's legit html. i assume it's done because of the modal here.IndexListRow.html:47ReplyAck -
Christian Kuhn commented on patch set 9 CR 0 02/15/23, 10:08
There is one systematic issue with this patch: It is possible to remove a user group, even if users are (directly or indirectly) attached to it. I think it would be really cool if the table listing would show number of members somehow, and the delete phrasing would change to something like "X users are still attached to this group, and this group is a sub-group of Y other groups. Are you sure ...". However, the 'list' module does not have something like that, either, so I guess we could go with the patch and think about further improvements in additional patches. -
Christian Kuhn voted on patch set 9 V +2 CR +2 02/15/23, 10:16
-
Christian Kuhn merged patch set 10 02/15/23, 10:17
locallang.xlf:171