Review main Merged

77774[TASK] Streamline permission treeview

Benjamin Kott CR +2 V +2 Hard +162 −135 updated 02/08/23, 09:49

Commit message

Enable record icons for better orientation and correct
display of tree lines. Moving the additional edit button to
the end of the table because has the same functionality as
clicking the item. The form styling was adjusted and does
not look out of place anymore.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1

Issues 1

Files 16

Review log 710

  1. Benjamin Kott uploaded patch set 1 02/07/23, 15:58

  2. core-ci voted on patch set 1 V -1 02/07/23, 17:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37298

  3. Benjamin Kott uploaded patch set 2 V -1 02/08/23, 07:56

  4. core-ci voted on patch set 2 V +1 02/08/23, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37334

  5. Benni Mack commented on patch set 2 V +1 CR +1 02/08/23, 08:29

    Thank you, I hope we can get rid of the "Save" disk button at some point as well
  6. Andreas Kienast uploaded patch set 3 CR +1 V +1 02/08/23, 09:29

  7. Andreas Kienast voted on patch set 3 V +1 CR +1 02/08/23, 09:29

  8. Benni Mack voted on patch set 3 V +2 CR +2 02/08/23, 09:30

  9. Benni Mack merged patch set 4 02/08/23, 09:30

  10. core-ci voted on patch set 3 V +1 02/08/23, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37344