Review main Merged

77779[BUGFIX] Fix PHP 8 warning in AbstractMenuContentObject

Thomas Hohn CR +2 V +2 Easy +3 −2 updated 02/13/23, 11:48

Commit message

Added Null coalescing operator, when value of
$this->mconf['sectionIndex.']['type'] is used.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Guido Schmechel +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Thomas Hohn uploaded patch set 1 02/07/23, 20:07

  2. Thomas Hohn uploaded patch set 2 02/07/23, 20:11

  3. core-ci voted on patch set 1 V +1 02/07/23, 20:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37314

  4. core-ci voted on patch set 2 V +1 02/07/23, 20:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37315

  5. Nikita Hovratov voted on patch set 2 V +1 CR +1 02/07/23, 22:25

  6. Oliver Klee voted on patch set 2 CR +1 02/07/23, 23:22

  7. Guido Schmechel voted on patch set 2 CR +1 02/11/23, 22:19

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 02/13/23, 11:48

  9. Christian Kuhn merged patch set 3 02/13/23, 11:48