Review main Merged

77780[FEATURE] Add keyboard support for Multiselect

Lukas Niestroj CR +2 V +2 Hard +312 −21 updated 03/24/23, 08:03

Commit message

This patch adds keyboard support for selecting and deselecting options in
Multiselect. This should lead into a more accessible behaviour in forms
with TCA configurations like: selectMultipleSideBySide, group or folder.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Guido Schmechel +1
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Guido Schmechel +1
    • Michael Telgkamp +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 2940

Show 915 earlier messages
  1. Lukas Niestroj uploaded patch set 1 02/07/23, 20:42

  2. core-ci voted on patch set 1 V +1 02/07/23, 20:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37316

  3. Lukas Niestroj uploaded patch set 2 V +1 02/08/23, 06:14

  4. core-ci voted on patch set 2 V +1 02/08/23, 06:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37323

  5. Lukas Niestroj uploaded patch set 3 V +1 02/08/23, 07:23

  6. core-ci voted on patch set 3 V +1 02/08/23, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37325

  7. Michael Telgkamp commented on patch set 3 V -1 02/08/23, 07:42

    Thank you for your patch, it is a major improvement for keyboard users, but please have a look at the WAI ARIA Pattern for listbox: https://www.w3.org/WAI/ARIA/apg/patterns/listbox/examples/listbox-rearrangeable/ The "Example 2: Multi-Select Listbox" looks like having most of the functionality, but uses a different keyboard pattern. In terms of accessibility it is always a good idea to use patterns that are commonly described.
    I suggest to write the modifier keys before the actual keystroke, So 'Alt' + 'ArrowUp' as it is common practice to write the keys that need to be pressed while pressing others first.
  8. Lukas Niestroj commented on patch set 3 02/08/23, 07:52

    Reply

    😯 thanks for the resource! Will definitly check that.

    Reply

    Thanks for your feedback. I will provide a new Changeset.
  9. Lukas Niestroj uploaded patch set 4 V +1 02/08/23, 21:23

  10. core-ci voted on patch set 4 V +1 02/08/23, 22:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37413

  11. Lukas Niestroj commented on patch set 4 02/13/23, 20:07

    This patch is ready for review.
  12. Lukas Niestroj uploaded patch set 5 V +1 02/15/23, 07:52

  13. core-ci voted on patch set 5 V +1 02/15/23, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37724

  14. Lukas Niestroj uploaded patch set 6 V +1 02/15/23, 16:36

  15. core-ci voted on patch set 6 V +1 02/15/23, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37771

  1. Lukas Niestroj uploaded patch set 7 V +1 03/14/23, 13:46

  2. core-ci voted on patch set 7 V +1 03/14/23, 14:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38927

  3. Georg Ringer commented on patch set 7 03/15/23, 11:04

    there is no Delete on mac, just backspace, so that doesn't work for me. I would suggest make this btw a feature and a rst
  4. Georg Ringer voted on patch set 7 V -1 03/15/23, 11:05

  5. Georg Ringer commented on patch set 7 03/15/23, 11:05

    sorry forgot to mention: rest is working fine and this is a really cool improvement!!
  6. Lukas Niestroj commented on patch set 7 03/16/23, 11:53

    Reply

    thx for the feedback. Will review this for Mac.
  7. Lukas Niestroj uploaded patch set 8 V +1 03/16/23, 12:13

  8. Oliver Klee updated the commit message in patch set 9 03/16/23, 12:21

  9. core-ci voted on patch set 8 V -1 03/16/23, 12:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39055

  10. core-ci voted on patch set 9 V -1 03/16/23, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39056

  11. Lukas Niestroj uploaded patch set 10 V -1 03/16/23, 19:29

  12. core-ci voted on patch set 10 V +1 03/16/23, 19:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39066

  13. Georg Ringer voted on patch set 10 V +1 CR +1 03/16/23, 19:59

  14. Michael Telgkamp commented on patch set 10 V +1 CR +1 03/17/23, 09:13

    Thank you very much for fixing this problem and improving the keyboard usability and the accessibility of TYPO3!
  15. Michael Telgkamp commented on patch set 10 CR -1 03/17/23, 09:18

    I just realized the rst file is missing, this is required for a Feature. https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/AddingDocumentation/Index.html#changelog Also this will help the documentation team to include the information into the docs.
  16. Michael Telgkamp commented on patch set 10 03/17/23, 09:38

    The RST is actually there (sorry I missed it) but it should be improved.

    Feature-97667-AddKeyboardSupportForSelectMultipleSideBySideGroupFolder.rst:13

    A short introduction in the description would be nice to have.

    Feature-97667-AddKeyboardSupportForSelectMultipleSideBySideGroupFolder.rst:14

    Single linebreaks will be removed in rst, please consider using a list here

    Feature-97667-AddKeyboardSupportForSelectMultipleSideBySideGroupFolder.rst:18

    For accessibility and readability reasons I think it would be better for write all options in a single line and not group the 'down' options in one of the up options.

    Feature-97667-AddKeyboardSupportForSelectMultipleSideBySideGroupFolder.rst:24

    I would suggest to use standard punctuation instead of /: > The user can now use the keyboard to add, move or remove options.
  17. Benni Mack commented on patch set 10 03/22/23, 19:38

    don't wait too long @michael as Feature Freeze is coming on tuesday! Very good improvement!
  18. Lukas Niestroj uploaded patch set 11 CR +1 V +1 03/23/23, 06:26

  19. Lukas Niestroj commented on patch set 11 03/23/23, 06:33

    When I add line breaks in my commit message after ~72 characters it looks weird in forge. How should I handle that in the future? I use PHPStorm as my IDE and have "Limit body line" configured to 72 as a "right margin".

    Feature-97667-AddKeyboardSupportForSelectMultipleSideBySideGroupFolder.rst:13 Reply

    Done

    Feature-97667-AddKeyboardSupportForSelectMultipleSideBySideGroupFolder.rst:14 Reply

    Done

    Feature-97667-AddKeyboardSupportForSelectMultipleSideBySideGroupFolder.rst:18 Reply

    Done

    Feature-97667-AddKeyboardSupportForSelectMultipleSideBySideGroupFolder.rst:24 Reply

    Done
  20. core-ci voted on patch set 11 V +1 03/23/23, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39440

  21. Georg Ringer voted on patch set 11 V +1 CR +1 03/23/23, 07:08

  22. Michael Telgkamp commented on patch set 11 V +1 CR +1 03/23/23, 07:39

    Thank you very much for improving the RST, looks much better now!

    Reply

    The linebreak for one line is actually after 74 characters. I will confirm this anyway, becaust the code is fine.
  23. Guido Schmechel commented on patch set 11 V +1 CR +1 03/23/23, 20:50

    Good job :-)
  24. Benni Mack voted on patch set 11 V +2 CR +2 03/24/23, 08:03

  25. Benni Mack merged patch set 12 03/24/23, 08:03