77780[FEATURE] Add keyboard support for Multiselect
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Guido Schmechel +1
- Michael Telgkamp +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Guido Schmechel +1
- Michael Telgkamp +1
- core-ci +1 CI
Issues 1
Files 7
- Build/Sources/TypeScript/backend/form-engine/element/abstract-sortable-select-items.ts+50 −2
- Build/Sources/TypeScript/backend/form-engine/element/select-multiple-side-by-side-element.ts+34 −17
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/abstract-sortable-select-items.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/select-multiple-side-by-side-element.js+1 −1
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-97667-AddKeyboardSupportForSelectMultipleSideBySideGroupFolder.rst8new+40 −0
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsGroupWithKeyboardCest.phpnew+111 −0
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsSelectMultipleSideBySideWithKeyboardCest.phpnew+75 −0
Review log 2940
Show 915 earlier messages
-
Lukas Niestroj uploaded patch set 1 02/07/23, 20:42
-
core-ci voted on patch set 1 V +1 02/07/23, 20:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37316
-
Lukas Niestroj uploaded patch set 2
V +102/08/23, 06:14 -
core-ci voted on patch set 2 V +1 02/08/23, 06:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37323
-
Lukas Niestroj uploaded patch set 3
V +102/08/23, 07:23 -
core-ci voted on patch set 3 V +1 02/08/23, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37325
-
Michael Telgkamp commented on patch set 3 V -1 02/08/23, 07:42
Thank you for your patch, it is a major improvement for keyboard users, but please have a look at the WAI ARIA Pattern for listbox: https://www.w3.org/WAI/ARIA/apg/patterns/listbox/examples/listbox-rearrangeable/ The "Example 2: Multi-Select Listbox" looks like having most of the functionality, but uses a different keyboard pattern. In terms of accessibility it is always a good idea to use patterns that are commonly described.I suggest to write the modifier keys before the actual keystroke, So 'Alt' + 'ArrowUp' as it is common practice to write the keys that need to be pressed while pressing others first. -
Lukas Niestroj commented on patch set 3 02/08/23, 07:52
Reply
😯 thanks for the resource! Will definitly check that.Reply
Thanks for your feedback. I will provide a new Changeset. -
Lukas Niestroj uploaded patch set 4
V +102/08/23, 21:23 -
core-ci voted on patch set 4 V +1 02/08/23, 22:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37413
-
Lukas Niestroj commented on patch set 4 02/13/23, 20:07
This patch is ready for review. -
Lukas Niestroj uploaded patch set 5
V +102/15/23, 07:52 -
core-ci voted on patch set 5 V +1 02/15/23, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37724
-
Lukas Niestroj uploaded patch set 6
V +102/15/23, 16:36 -
core-ci voted on patch set 6 V +1 02/15/23, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37771
-
Lukas Niestroj uploaded patch set 7
V +103/14/23, 13:46 -
core-ci voted on patch set 7 V +1 03/14/23, 14:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38927
-
Georg Ringer commented on patch set 7 03/15/23, 11:04
there is no Delete on mac, just backspace, so that doesn't work for me. I would suggest make this btw a feature and a rst -
Georg Ringer voted on patch set 7 V -1 03/15/23, 11:05
-
Georg Ringer commented on patch set 7 03/15/23, 11:05
sorry forgot to mention: rest is working fine and this is a really cool improvement!! -
Lukas Niestroj commented on patch set 7 03/16/23, 11:53
Reply
thx for the feedback. Will review this for Mac. -
Lukas Niestroj uploaded patch set 8
V +103/16/23, 12:13 -
Oliver Klee updated the commit message in patch set 9 03/16/23, 12:21
-
core-ci voted on patch set 8 V -1 03/16/23, 12:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39055
-
core-ci voted on patch set 9 V -1 03/16/23, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39056
-
Lukas Niestroj uploaded patch set 10
V -103/16/23, 19:29 -
core-ci voted on patch set 10 V +1 03/16/23, 19:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39066
-
Georg Ringer voted on patch set 10 V +1 CR +1 03/16/23, 19:59
-
Michael Telgkamp commented on patch set 10 V +1 CR +1 03/17/23, 09:13
Thank you very much for fixing this problem and improving the keyboard usability and the accessibility of TYPO3! -
Michael Telgkamp commented on patch set 10 CR -1 03/17/23, 09:18
I just realized the rst file is missing, this is required for a Feature. https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/AddingDocumentation/Index.html#changelog Also this will help the documentation team to include the information into the docs. -
Michael Telgkamp commented on patch set 10 03/17/23, 09:38
The RST is actually there (sorry I missed it) but it should be improved.Feature-97667-AddKeyboardSupportForSelectMultipleSideBySideGroupFolder.rst:13A short introduction in the description would be nice to have.Feature-97667-AddKeyboardSupportForSelectMultipleSideBySideGroupFolder.rst:14Single linebreaks will be removed in rst, please consider using a list hereFeature-97667-AddKeyboardSupportForSelectMultipleSideBySideGroupFolder.rst:18For accessibility and readability reasons I think it would be better for write all options in a single line and not group the 'down' options in one of the up options.Feature-97667-AddKeyboardSupportForSelectMultipleSideBySideGroupFolder.rst:24I would suggest to use standard punctuation instead of /: > The user can now use the keyboard to add, move or remove options. -
Benni Mack commented on patch set 10 03/22/23, 19:38
don't wait too long @michael as Feature Freeze is coming on tuesday! Very good improvement! -
Lukas Niestroj uploaded patch set 11
CR +1V +103/23/23, 06:26 -
Lukas Niestroj commented on patch set 11 03/23/23, 06:33
When I add line breaks in my commit message after ~72 characters it looks weird in forge. How should I handle that in the future? I use PHPStorm as my IDE and have "Limit body line" configured to 72 as a "right margin".Feature-97667-AddKeyboardSupportForSelectMultipleSideBySideGroupFolder.rst:13ReplyDoneFeature-97667-AddKeyboardSupportForSelectMultipleSideBySideGroupFolder.rst:14ReplyDoneFeature-97667-AddKeyboardSupportForSelectMultipleSideBySideGroupFolder.rst:18ReplyDoneFeature-97667-AddKeyboardSupportForSelectMultipleSideBySideGroupFolder.rst:24ReplyDone -
core-ci voted on patch set 11 V +1 03/23/23, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39440
-
Georg Ringer voted on patch set 11 V +1 CR +1 03/23/23, 07:08
-
Michael Telgkamp commented on patch set 11 V +1 CR +1 03/23/23, 07:39
Thank you very much for improving the RST, looks much better now!Reply
The linebreak for one line is actually after 74 characters. I will confirm this anyway, becaust the code is fine. -
Guido Schmechel commented on patch set 11 V +1 CR +1 03/23/23, 20:50
Good job :-) -
Benni Mack voted on patch set 11 V +2 CR +2 03/24/23, 08:03
-
Benni Mack merged patch set 12 03/24/23, 08:03