Review main Merged

77786[TASK] Streamline typo3-backend-editable-page-title

Benjamin Kott CR +2 V +2 Hard +277 −77 updated 02/08/23, 16:34

Commit message

The editable page component now looks and feels like a
regular h1 element, and keeps this appereance when edit
mode is triggered. The new edit mode blends in and avoids
layout shifts as much as possible.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 913

  1. Benjamin Kott uploaded patch set 1 02/08/23, 12:43

  2. core-ci voted on patch set 1 V -1 02/08/23, 12:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37357

  3. Andreas Kienast commented on patch set 1 CR -1 02/08/23, 13:29

    editable-page-title.ts:31

    This breaks the acceptance tests now. :/

    editable-page-title.ts:146

    This can be shortened now: ``` return html`<h1>${this.pageTitle}</h1>`; ``` The variable `pageTitleHeadline` can be removed then.
  4. Benjamin Kott uploaded patch set 2 CR -1 V -1 02/08/23, 14:18

  5. Benjamin Kott uploaded patch set 3 02/08/23, 14:22

  6. Benjamin Kott commented on patch set 3 02/08/23, 14:22

    editable-page-title.ts:31 Reply

    Done

    editable-page-title.ts:146 Reply

    Done
  7. Benjamin Kott uploaded patch set 4 02/08/23, 14:38

  8. core-ci voted on patch set 2 V -1 02/08/23, 14:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37376

  9. core-ci voted on patch set 3 V -1 02/08/23, 14:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37377

  10. core-ci voted on patch set 4 V +1 02/08/23, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37382

  11. Andreas Kienast voted on patch set 4 V +1 CR +1 02/08/23, 14:51

  12. Benni Mack voted on patch set 4 V +2 CR +2 02/08/23, 16:34

  13. Benni Mack merged patch set 5 02/08/23, 16:34