77786[TASK] Streamline typo3-backend-editable-page-title
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 10
- Build/Sources/Sass/element/typo3-backend-editable-page-title.scssnew+7 −0
- Build/Sources/Sass/backend.scss+5 −0
- Build/Sources/TypeScript/backend/element/editable-page-title.ts4+128 −35
- Build/Sources/TypeScript/backend/element/icon-element.ts+0 −2
- typo3/sysext/backend/Resources/Public/Css/backend.css+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/element/editable-page-title.js+117 −21
- typo3/sysext/backend/Resources/Public/JavaScript/element/icon-element.js+0 −2
- typo3/sysext/core/Tests/Acceptance/Application/Page/PageModuleCest.php+12 −11
- typo3/sysext/core/Tests/Acceptance/Application/RecordList/SysNoteCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/Workspace/WorkspaceModuleCest.php+5 −3
Review log 913
-
Benjamin Kott uploaded patch set 1 02/08/23, 12:43
-
core-ci voted on patch set 1 V -1 02/08/23, 12:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37357
-
Andreas Kienast commented on patch set 1 CR -1 02/08/23, 13:29
editable-page-title.ts:146This can be shortened now: ``` return html`<h1>${this.pageTitle}</h1>`; ``` The variable `pageTitleHeadline` can be removed then. -
Benjamin Kott uploaded patch set 2
CR -1V -102/08/23, 14:18 -
Benjamin Kott uploaded patch set 3 02/08/23, 14:22
-
Benjamin Kott commented on patch set 3 02/08/23, 14:22
editable-page-title.ts:31ReplyDoneeditable-page-title.ts:146ReplyDone -
Benjamin Kott uploaded patch set 4 02/08/23, 14:38
-
core-ci voted on patch set 2 V -1 02/08/23, 14:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37376
-
core-ci voted on patch set 3 V -1 02/08/23, 14:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37377
-
core-ci voted on patch set 4 V +1 02/08/23, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37382
-
Andreas Kienast voted on patch set 4 V +1 CR +1 02/08/23, 14:51
-
Benni Mack voted on patch set 4 V +2 CR +2 02/08/23, 16:34
-
Benni Mack merged patch set 5 02/08/23, 16:34
editable-page-title.ts:31