Review main Abandoned

77787[BUGFIX] Fix PHP 8 warning in BackendUtility

Thomas Hohn CR 0 V 0 Easy +1 −1 updated 02/08/23, 14:22

Commit message

Added guards to catch faulty TCA configurations for items.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 68

  1. Thomas Hohn uploaded patch set 1 02/08/23, 13:24

  2. core-ci voted on patch set 1 V -1 02/08/23, 13:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37364

  3. Nikita Hovratov commented on patch set 1 CR -1 02/08/23, 13:50

    Type select fields require at least a label and a value in their items list. Something will fail sooner or later, so hiding this error here just postpones falling on your nose.
  4. Thomas Hohn uploaded patch set 2 CR -1 V -1 02/08/23, 13:54

  5. Thomas Hohn commented on patch set 2 02/08/23, 13:59

  6. Nikita Hovratov commented on patch set 2 02/08/23, 14:01

    Reply Unresolved

    If you look for usages in the core, it is only used for type=select
  7. core-ci voted on patch set 2 V +1 02/08/23, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37370

  8. Thomas Hohn abandoned the change 02/08/23, 14:22

    Not relevant