Review main Merged

77789[BUGFIX] Check for array key in FlexFormService

Sybille Peters CR +2 V +2 Easy +1 −1 updated 02/10/23, 08:12

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Sybille Peters uploaded patch set 1 02/08/23, 17:12

  2. core-ci voted on patch set 1 V +1 02/08/23, 17:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37392

  3. JAKOTA Design Group GmbH commented on patch set 1 02/08/23, 19:12

    FlexFormService.php:44

    How about something like? if (!is_array($languages[$languagePointer] ?? false)) { It is just a bit more readable, but maybe that is just me.
  4. Georg Ringer commented on patch set 1 02/08/23, 21:35

    FlexFormService.php:44 Reply

    yes please go this way
  5. Sybille Peters uploaded patch set 2 V +1 02/09/23, 07:42

  6. Sybille Peters commented on patch set 2 02/09/23, 07:43

    FlexFormService.php:44 Reply

    Done
  7. core-ci voted on patch set 2 V +1 02/09/23, 07:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37426

  8. Oliver Klee voted on patch set 2 CR +1 02/09/23, 13:21

  9. Georg Ringer voted on patch set 2 V +1 CR +1 02/10/23, 07:59

  10. Oli Bartsch voted on patch set 2 V +2 CR +2 02/10/23, 08:12

  11. Oli Bartsch merged patch set 3 02/10/23, 08:12