Review main Merged

77796[BUGFIX] Live Search: Rework registration of renderers and invoke handlers

Andreas Kienast CR +2 V +2 Normal +114 −54 updated 02/10/23, 14:58

Commit message

This patch introduces a new global `LiveSearchConfigurator` module that
can be used anywhere in the TYPO3 backend to load configuration of the
Live Search.

The methods `LiveSearch.addRenderer()` and
`LiveSearch.addInvokeHandler()` were removed. Instead,
`LiveSearchConfigurator` should be used. Web components where thinned
out to not rely on getting such configuration handed in anymore.

However, there's a small API change:
`LiveSearchConfigurator.addRenderer()` now requires a new argument
`module` to be able to load modules on-demand if they were not loaded
already in the current backend scope.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Frank Nägler +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 69

  1. Andreas Kienast uploaded patch set 1 02/09/23, 09:15

  2. Andreas Kienast uploaded patch set 2 02/09/23, 09:17

  3. core-ci voted on patch set 1 V +1 02/09/23, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37432

  4. core-ci voted on patch set 2 V +1 02/09/23, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37433

  5. Andreas Kienast uploaded patch set 3 V +1 02/10/23, 10:21

  6. Frank Nägler voted on patch set 3 V +1 CR +1 02/10/23, 10:25

  7. core-ci voted on patch set 3 V +1 02/10/23, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37540

  8. Benni Mack voted on patch set 3 V +2 CR +2 02/10/23, 14:58

  9. Benni Mack merged patch set 4 02/10/23, 14:58