77798[FEATURE] Introduce TCA type "json"
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Benni Mack +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 2
Files 31
- Build/Sources/TypeScript/backend/form-engine/element/json-element.tsnew+45 −0
- Build/Sources/TypeScript/t3editor/element/code-mirror-element.ts+15 −1
- typo3/sysext/backend/Classes/Form/Element/JsonElement.phpnew+247 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaColumnsProcessPlaceholders.php+1 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInputPlaceholders.php+1 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaJson.phpnew+51 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaRecordTitle.php+3 −0
- typo3/sysext/backend/Classes/Form/Utility/FormEngineUtility.php+1 −0
- typo3/sysext/backend/Classes/Form/NodeFactory.php+1 −0
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+2 −0
- typo3/sysext/backend/Classes/Search/LiveSearch/DatabaseRecordProvider.php+1 −0
- typo3/sysext/backend/Classes/Utility/BackendUtility.php2+20 −18
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/json-element.jsnew+13 −0
- typo3/sysext/backend/Tests/Unit/Form/Element/JsonElementTest.phpnew+118 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaJsonTest.phpnew+241 −0
- typo3/sysext/core/Classes/Database/Schema/DefaultTcaSchema.php1+87 −69
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+38 −4
- typo3/sysext/core/Classes/DataHandling/TableColumnType.php+1 −0
- typo3/sysext/core/Classes/Resource/Search/QueryRestrictions/SearchTermRestriction.php+1 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+17 −2
Show 11 more files
- typo3/sysext/core/Documentation/Changelog/12.1/Feature-99226-IntroduceDbTypeJsonForTCATypeUser.rst2+8 −0
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-100088-NewTCATypeJson.rstnew+58 −0
- typo3/sysext/core/Documentation/Changelog/12.3/Important-100088-RemoveDbTypeJsonForTCATypeUser.rstnew+48 −0
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+36 −0
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapFactoryTest.php+1 −0
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php+2 −0
- typo3/sysext/reactions/Classes/Form/Element/FieldMapElement.php+1 −1
- typo3/sysext/reactions/Configuration/TCA/Overrides/sys_reaction_create_record.php+1 −3
- typo3/sysext/reactions/ext_tables.sql+0 −1
- typo3/sysext/t3editor/Configuration/Backend/T3editor/Modes.php+4 −0
- typo3/sysext/t3editor/Resources/Public/JavaScript/element/code-mirror-element.js+3 −3
Review log 2739
Show 1014 earlier messages
-
Frank Nägler uploaded patch set 1 02/09/23, 11:39
-
core-ci voted on patch set 1 V -1 02/09/23, 11:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37438
-
Frank Nägler uploaded patch set 2
V -102/09/23, 12:54 -
core-ci voted on patch set 2 V +1 02/09/23, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37450
-
Benni Mack commented on patch set 2 02/09/23, 14:37
should we just use a type=text, and dbType=json and renderType=code or something like that? -
Frank Nägler commented on patch set 2 02/10/23, 11:26
Reply
To be honest, I don't care, for me the whole system with type, dbType and rednerTypo is confusing. JSON is pure text, but JSON is stored as JSON in DB, rendering can be a textarea without t3editor or as code-mirror field if t3editor is installed (checks are missing btw). DataHandler (at the moment) handles JSON only as type=user and dbType=json. I am missing a concept here, or I did not see it yet. -
Frank Nägler marked it work in progress 02/10/23, 11:26
-
Frank Nägler commented on patch set 2 02/10/23, 11:27
This change is ready for review.Reply
and my test record is configured like that at the moment: 't3editor_3' => [ 'label' => 't3editor_3', 'description' => '', 'config' => [ 'type' => 'json', 'dbType' => 'json', 'default' => null, ], ], -
Frank Nägler marked it work in progress 02/10/23, 11:27
-
Frank Nägler rebased onto patch set 3
V +102/23/23, 12:52 -
core-ci voted on patch set 3 V +1 02/23/23, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38017
-
Oli Bartsch rebased onto patch set 4
V +102/24/23, 12:41 -
core-ci voted on patch set 4 V +1 02/24/23, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38053
-
Oli Bartsch uploaded patch set 5
V +103/04/23, 21:48
-
core-ci voted on patch set 5 V +1 03/04/23, 21:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38458
-
Oli Bartsch uploaded patch set 6
V +103/04/23, 22:07 -
Oli Bartsch marked it ready for review 03/04/23, 22:07
-
core-ci voted on patch set 6 V +1 03/04/23, 22:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38459
-
Simon Schaufelberger commented on patch set 6 03/05/23, 03:22
Feature-99226-IntroduceDbTypeJsonForTCATypeUser.rst:1I'm not sure if it is wise to delete that file as it still relates to a forge issue. -
Oli Bartsch uploaded patch set 7
V +103/05/23, 09:23 -
Oli Bartsch commented on patch set 7 03/05/23, 09:23
Feature-99226-IntroduceDbTypeJsonForTCATypeUser.rst:1ReplyGood point. Added a warning on top instead. -
core-ci voted on patch set 7 V +1 03/05/23, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38481
-
Oli Bartsch uploaded patch set 8
V +103/05/23, 09:38 -
core-ci voted on patch set 8 V +1 03/05/23, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38482
-
Benni Mack commented on patch set 8 03/06/23, 08:28
BackendUtility.php:1550can now be moved to the switch/case statement -
Nikita Hovratov uploaded patch set 9
V +103/06/23, 09:31 -
Nikita Hovratov commented on patch set 8 03/06/23, 09:31
BackendUtility.php:1550ReplyDone -
core-ci voted on patch set 9 V +1 03/06/23, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38524
-
Nikita Hovratov uploaded patch set 10
V +103/06/23, 09:47 -
Nikita Hovratov voted on patch set 10 V +1 CR +1 03/06/23, 09:47
-
Nikita Hovratov uploaded patch set 11
CR +1V +103/06/23, 09:52 -
core-ci voted on patch set 10 V +1 03/06/23, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38527
-
core-ci voted on patch set 11 V -1 03/06/23, 10:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38530
-
Nikita Hovratov uploaded patch set 12
V -103/06/23, 10:41 -
core-ci voted on patch set 12 V +1 03/06/23, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38541
-
Nikita Hovratov voted on patch set 12 V +1 CR +1 03/06/23, 11:06
-
Benni Mack voted on patch set 12 V +2 CR +2 03/06/23, 12:00
-
Benni Mack merged patch set 13 03/06/23, 12:00
-
Stefan Bürk commented on patch set 13 03/07/23, 05:33
DefaultTcaSchema.php:520Post -1 Default values for `json` fields are not allowed by all DBMS. Fix: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78043