Review main Merged

77804[BUGFIX] Avoid layout shifts when moving content elements

Benjamin Kott CR +2 V +2 Easy +34 −10 updated 02/09/23, 16:49

Commit message

To avoid layout shifts when dragging elements in the page
layout module, we are now creating a clone that consumes
the original space when dragging the element.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jasmina Ließmann +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 810

  1. Benjamin Kott uploaded patch set 1 02/09/23, 14:15

  2. Benni Mack commented on patch set 1 02/09/23, 14:19

    should we start investing in HTML5-native drag+drop?
  3. core-ci voted on patch set 1 V +1 02/09/23, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37466

  4. Benjamin Kott commented on patch set 1 02/09/23, 14:43

    Reply

    sure, but would have taken more time to adjust than just adding the clones. we can do this at a later point, andi is more into that topic
  5. Benjamin Kott uploaded patch set 2 V +1 02/09/23, 14:47

  6. core-ci voted on patch set 2 V +1 02/09/23, 15:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37475

  7. Andreas Kienast voted on patch set 2 V +1 CR +1 02/09/23, 15:04

  8. Jasmina Ließmann voted on patch set 2 V +1 02/09/23, 15:30

  9. Benni Mack voted on patch set 2 V +2 CR +2 02/09/23, 16:49

  10. Benni Mack merged patch set 3 02/09/23, 16:49