77806[TASK] Deprecate the limit parameter for GU::intExplode
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Nikita Hovratov +1
- Andreas Kienast +1
-
Verified V +2 Done
- Christian Kuhn +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1722
-
Oliver Klee uploaded patch set 1 02/09/23, 14:28
-
Oliver Klee rebased onto patch set 2 02/09/23, 14:28
-
Oliver Klee uploaded patch set 3 02/09/23, 14:29
-
Nikita Hovratov commented on patch set 3 02/09/23, 16:59
Note to reviewers: This parameter was added back in the days, because this method used to use trimExplode internally: 648cd2bed8330e5a1f674d3c8665a7518d92d738 Later it was removed again, but the parameter stayed: https://review.typo3.org/c/Packages/TYPO3.CMS/+/26740 It makes absolutely no sense for this method to limit the result and then combine the rest to a string. It's only there because of historical reasons. -
Christian Kuhn rebased onto patch set 4 02/09/23, 19:30
-
Christian Kuhn commented on patch set 4 02/09/23, 19:30
rebasing just to trigger gitlab again, it did not vote for whatever reason. -
Oliver Klee commented on patch set 4 02/09/23, 19:48
Reply
Ah, I canceled the builds as this was still a WIP and I didn’t want to hog the CI resources with this WIP change. :-) -
core-ci voted on patch set 4 V +1 02/09/23, 19:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37497
-
Oliver Klee uploaded patch set 5
V +102/13/23, 13:14 -
core-ci voted on patch set 5 V -1 02/13/23, 13:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37649
-
Oliver Klee uploaded patch set 6
V -102/13/23, 13:54 -
core-ci voted on patch set 6 V +1 02/13/23, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37651
-
Andreas Kienast commented on patch set 6 CR -1 02/13/23, 15:38
GeneralUtility.php:852Please add `__METHOD__` or `GeneralUtility::intExplode()` somewhere in the sentence, so reading the deprecation log will give a hint where the entry comes from. -
Oliver Klee uploaded patch set 7
CR -1V +102/13/23, 16:09 -
Oliver Klee commented on patch set 7 02/13/23, 16:09
GeneralUtility.php:852ReplyDone -
core-ci voted on patch set 7 V +1 02/13/23, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37656
-
Nikita Hovratov uploaded patch set 8
V +102/14/23, 08:51 -
Nikita Hovratov voted on patch set 8 V +1 CR +1 02/14/23, 08:51
-
core-ci voted on patch set 8 V +1 02/14/23, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37675
-
Andreas Kienast voted on patch set 8 CR +1 02/14/23, 09:26
-
Christian Kuhn voted on patch set 8 V +2 CR +2 02/14/23, 10:09
-
Christian Kuhn merged patch set 9 02/14/23, 10:09