Review main Merged

77806[TASK] Deprecate the limit parameter for GU::intExplode

Oliver Klee CR +2 V +2 Normal +53 −1 updated 02/14/23, 10:09

Commit message

Passing a limit to `GU::intExplode` will cause the method to
potentially return a string as the last array element, which
is not documented and directly contradicts the method contract
(which states that an array of integers will be returned).

The deprecated parameter is not used in the Core at all.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1722

  1. Oliver Klee uploaded patch set 1 02/09/23, 14:28

  2. Oliver Klee rebased onto patch set 2 02/09/23, 14:28

  3. Oliver Klee uploaded patch set 3 02/09/23, 14:29

  4. Nikita Hovratov commented on patch set 3 02/09/23, 16:59

    Note to reviewers: This parameter was added back in the days, because this method used to use trimExplode internally: 648cd2bed8330e5a1f674d3c8665a7518d92d738 Later it was removed again, but the parameter stayed: https://review.typo3.org/c/Packages/TYPO3.CMS/+/26740 It makes absolutely no sense for this method to limit the result and then combine the rest to a string. It's only there because of historical reasons.
  5. Christian Kuhn rebased onto patch set 4 02/09/23, 19:30

  6. Christian Kuhn commented on patch set 4 02/09/23, 19:30

    rebasing just to trigger gitlab again, it did not vote for whatever reason.
  7. Oliver Klee commented on patch set 4 02/09/23, 19:48

    Reply

    Ah, I canceled the builds as this was still a WIP and I didn’t want to hog the CI resources with this WIP change. :-)
  8. core-ci voted on patch set 4 V +1 02/09/23, 19:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37497

  9. Oliver Klee uploaded patch set 5 V +1 02/13/23, 13:14

  10. core-ci voted on patch set 5 V -1 02/13/23, 13:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37649

  11. Oliver Klee uploaded patch set 6 V -1 02/13/23, 13:54

  12. core-ci voted on patch set 6 V +1 02/13/23, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37651

  13. Andreas Kienast commented on patch set 6 CR -1 02/13/23, 15:38

    GeneralUtility.php:852

    Please add `__METHOD__` or `GeneralUtility::intExplode()` somewhere in the sentence, so reading the deprecation log will give a hint where the entry comes from.
  14. Oliver Klee uploaded patch set 7 CR -1 V +1 02/13/23, 16:09

  15. Oliver Klee commented on patch set 7 02/13/23, 16:09

    GeneralUtility.php:852 Reply

    Done
  16. core-ci voted on patch set 7 V +1 02/13/23, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37656

  17. Nikita Hovratov uploaded patch set 8 V +1 02/14/23, 08:51

  18. Nikita Hovratov voted on patch set 8 V +1 CR +1 02/14/23, 08:51

  19. core-ci voted on patch set 8 V +1 02/14/23, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37675

  20. Andreas Kienast voted on patch set 8 CR +1 02/14/23, 09:26

  21. Christian Kuhn voted on patch set 8 V +2 CR +2 02/14/23, 10:09

  22. Christian Kuhn merged patch set 9 02/14/23, 10:09