Review main Merged

77808[BUGFIX] Guard ConstantEditor with copy operator in constants

Stefan Bürk CR +2 V +2 Easy +1 −0 updated 02/14/23, 12:13

Commit message

If copy operator '<' is used in TypoScript constants for a
constant with a constant editor configuration comment, the
"Call to member function getType() on null" exception is
emitted.

Example TypoScript constants:

>  # cat=custom/a; type=color; label=Primary Color
>  plugin.tx_example.primaryColor = #282E31
>
>  # cat=custom/a; type=color; label=Other Color
>  plugin.tx_example.otherColor < plugin.tx_example.primaryColor

This may happen when a comment token stream is
handled multiple times without being reset properly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 79

  1. Stefan Bürk uploaded patch set 1 02/09/23, 17:51

  2. Christian Kuhn commented on patch set 1 CR -1 02/09/23, 17:57

    need to debug this, unsure if maybe something else is wrong, too.
  3. core-ci voted on patch set 1 V +1 02/09/23, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37486

  4. Christian Kuhn uploaded patch set 2 CR -1 V +1 02/14/23, 11:50

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 02/14/23, 11:51

  6. core-ci voted on patch set 2 V +1 02/14/23, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37686

  7. Oli Bartsch voted on patch set 2 V +1 CR +1 02/14/23, 12:01

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 02/14/23, 12:13

  9. Christian Kuhn merged patch set 3 02/14/23, 12:13