Review main Merged

77816[BUGFIX] Handle Exceptions on CLI

Christoph Lehmann CR +2 V +2 Easy +1 −0 updated 04/20/23, 15:18

Commit message

With this Exceptions on CLI are not caught
by \Symfony\Component\Console\Application anymore
and handled by TYPO3's SYS/productionExceptionHandler
or SYS/debugExceptionHandler.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1114

  1. Christoph Lehmann uploaded patch set 1 02/09/23, 22:45

  2. Christoph Lehmann commented on patch set 1 02/09/23, 22:51

    The output of Symfonys Error Handler is more beautiful with colors and a Stacktrace, but in the end I think this is a bug. Symfony: ./typo3/sysext/core/bin/typo3 cleanup:deletedrecords -vvv In DeletedRecordsCommand.php line 81: [Exception] test Exception trace: at /Users/lehmann/src/typo3/TYPO3.CMS/typo3/sysext/lowlevel/Classes/Command/DeletedRecordsCommand.php:81 TYPO3\CMS\Lowlevel\Command\DeletedRecordsCommand->execute() at /Users/lehmann/src/typo3/TYPO3.CMS/vendor/symfony/console/Command/Command.php:312 Symfony\Component\Console\Command\Command->run() at /Users/lehmann/src/typo3/TYPO3.CMS/vendor/symfony/console/Application.php:1040 Symfony\Component\Console\Application->doRunCommand() at /Users/lehmann/src/typo3/TYPO3.CMS/vendor/symfony/console/Application.php:314 Symfony\Component\Console\Application->doRun() at /Users/lehmann/src/typo3/TYPO3.CMS/vendor/symfony/console/Application.php:168 Symfony\Component\Console\Application->run() at /Users/lehmann/src/typo3/TYPO3.CMS/typo3/sysext/core/Classes/Console/CommandApplication.php:117 TYPO3\CMS\Core\Console\CommandApplication->run() at /Users/lehmann/src/typo3/TYPO3.CMS/typo3/sysext/core/bin/typo3:24 {closure}() at /Users/lehmann/src/typo3/TYPO3.CMS/typo3/sysext/core/bin/typo3:25 cleanup:deletedrecords [-p|--pid PID] [-d|--depth DEPTH] [--dry-run] TYPO3: ./typo3/sysext/core/bin/typo3 cleanup:deletedrecords -vvv Uncaught TYPO3 Exception test thrown in file /Users/lehmann/src/typo3/TYPO3.CMS/typo3/sysext/lowlevel/Classes/Command/DeletedRecordsCommand.php in line 81
  3. core-ci voted on patch set 1 V +1 02/09/23, 22:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37511

  4. Georg Ringer updated the commit message in patch set 2 V +1 02/10/23, 07:56

  5. core-ci voted on patch set 2 V +1 02/10/23, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37526

  6. Benni Mack voted on patch set 2 V +1 CR +1 03/06/23, 14:56

  7. Torben Hansen voted on patch set 2 V +1 CR +1 03/26/23, 05:53

  8. Oliver Klee voted on patch set 2 CR +1 03/26/23, 08:21

  9. Christian Kuhn uploaded patch set 3 CR +1 V +1 04/20/23, 14:57

  10. Oliver Klee voted on patch set 3 CR +1 04/20/23, 15:11

  11. core-ci voted on patch set 3 V +1 04/20/23, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40985

  12. Benni Mack voted on patch set 3 V +1 CR +1 04/20/23, 15:18

  13. Christian Kuhn voted on patch set 3 V +2 CR +2 04/20/23, 15:18

  14. Christian Kuhn merged patch set 4 04/20/23, 15:18