Review main Merged

77821[BUGFIX] Filter empty filelist actions after dispatching ProcessFileListActionsEvent

Andreas Kienast CR +2 V +2 Easy +4 −4 updated 02/10/23, 11:32

Commit message

When listing the contents of the folder "form_definitions",
`ProcessFileListActionsEventListener` modifies the available actions in
that directory by setting any disallowed action to `null`. With #99861,
a necessary null check was removed, leading to PHP warnings.

To solve the issue, `ProcessFileListActionsEventListener` now unsets
disallowed actions. Additionally, the `array_filter()` call to remove
empty actions is now executed after handling the
`ProcessFileListActionsEvent` event.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Thomas Hohn +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1012

  1. Andreas Kienast uploaded patch set 1 02/10/23, 10:09

  2. Thomas Hohn voted on patch set 1 CR +1 02/10/23, 10:13

  3. core-ci voted on patch set 1 V +1 02/10/23, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37539

  4. Oliver Klee voted on patch set 1 CR +1 02/10/23, 10:22

  5. Andreas Kienast voted on patch set 1 CR -1 02/10/23, 10:32

  6. Andreas Kienast uploaded patch set 2 CR +1 V +1 02/10/23, 10:38

  7. Benni Mack voted on patch set 2 CR +1 02/10/23, 10:40

  8. Thomas Hohn voted on patch set 2 CR +1 02/10/23, 10:42

  9. core-ci voted on patch set 2 V +1 02/10/23, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37542

  10. Benjamin Kott voted on patch set 2 V +1 CR +1 02/10/23, 11:24

  11. Benni Mack voted on patch set 2 V +2 CR +2 02/10/23, 11:32

  12. Benni Mack merged patch set 3 02/10/23, 11:32