Review main Merged

77822[BUGFIX] Edit buttons using current language-scope in page module

Benjamin Kott CR +2 V +2 Normal +83 −69 updated 02/10/23, 16:40

Commit message

The page module is a language-scoped view of pages. The user is always
in a language context. The language context is respected by all actions
within the module, except the edit button in the module bar. Instead of
respecting the context, a second button is added to enter the translated
page properties.

This is a problem, because the language context is ignored and the user
now faces a button with a different behavior, using the same voice and
tone on their labels.

For example the "view" button does not change the label and openes the
current page always in the selected language. The "edit" button also does
not change the label, but opens always the default language record.

This is a heavy inconsitency in the user experience and needs to be
addressed.

We are now adjusting this to have the edit button always visible and
disable the button if the user has no permission to perform the task.
The edit button will now always respect the the current selected
language and the additional button is therefore dropped.

In the language comparison view, the edit and view buttons are
now removed, because those action buttons already exist on the
corresponding language columns.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1321

  1. Benjamin Kott uploaded patch set 1 02/10/23, 11:21

  2. Benjamin Kott uploaded patch set 2 02/10/23, 11:25

  3. Benjamin Kott uploaded patch set 3 02/10/23, 11:26

  4. Benjamin Kott uploaded patch set 4 02/10/23, 11:28

  5. core-ci voted on patch set 1 V -1 02/10/23, 11:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37545

  6. core-ci voted on patch set 4 V +1 02/10/23, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37548

  7. core-ci voted on patch set 3 V -1 02/10/23, 11:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37547

  8. core-ci voted on patch set 2 V -1 02/10/23, 12:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37546

  9. Benjamin Kott uploaded patch set 5 V +1 02/10/23, 13:03

  10. Andreas Kienast uploaded patch set 6 02/10/23, 13:24

  11. core-ci voted on patch set 5 V -1 02/10/23, 13:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37555

  12. Andreas Kienast uploaded patch set 7 02/10/23, 13:41

  13. core-ci voted on patch set 6 V -1 02/10/23, 13:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37556

  14. core-ci voted on patch set 7 V +1 02/10/23, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37557

  15. Andreas Kienast voted on patch set 7 V +1 CR +1 02/10/23, 14:14

  16. Oli Bartsch commented on patch set 7 CR -1 02/10/23, 15:00

    Review
  17. Oli Bartsch uploaded patch set 8 CR +1 V +1 02/10/23, 15:46

  18. Oli Bartsch voted on patch set 8 V +1 CR +1 02/10/23, 15:47

  19. core-ci voted on patch set 8 V +1 02/10/23, 15:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37575

  20. Stefan Bürk voted on patch set 8 V +2 CR +2 02/10/23, 16:40

  21. Stefan Bürk merged patch set 9 02/10/23, 16:40