Review main Merged

77823[TASK] Move language selection after mode selection in page module

Benjamin Kott CR +2 V +2 Normal +76 −39 updated 02/12/23, 11:41

Commit message

The page module has currently two different modes, the layout and the
language comparison mode. To improve the usability we are moving the
language selection after the mode selection. This will help the user
to understand the context of the language switch better.

In addition we are improving the naming on the modes.
-> Columns -> Layout
-> Languages -> Language Comparision

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1927

Show 12 earlier messages
  1. Benjamin Kott uploaded patch set 1 02/10/23, 12:46

  2. core-ci voted on patch set 1 V -1 02/10/23, 13:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37553

  1. Josef Glatz commented on patch set 1 02/10/23, 13:21

    locallang_core.xlf:179

    I wonder if we should introduce another "Language" source string as we have already the exact same (used in mainly in TCA) in EXT:core/Resources/Private/Language/locallang_general.xlf:LGL.language. I'm actually not sure what xlf files are the generic/general ones, but if this source string will most likely be "Language" we could use an existing general one.
  2. Benjamin Kott uploaded patch set 2 V -1 02/10/23, 13:57

  3. Benjamin Kott commented on patch set 2 02/10/23, 14:01

    locallang_core.xlf:179 Reply

    I would suggest that these labels are the generic ones, the others are also named strange.
  4. core-ci voted on patch set 2 V +1 02/10/23, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37561

  5. Josef Glatz commented on patch set 2 02/10/23, 15:11

    locallang_core.xlf:179 Reply

    Ack
  6. Josef Glatz updated the commit message in patch set 3 V +1 02/10/23, 15:12

  7. core-ci voted on patch set 3 V +1 02/10/23, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37573

  8. Oli Bartsch uploaded patch set 4 V +1 02/10/23, 17:34

  9. core-ci voted on patch set 4 V +1 02/10/23, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37577

  10. Oli Bartsch uploaded patch set 5 V +1 02/10/23, 20:41

  11. Oli Bartsch voted on patch set 5 V +1 CR +1 02/10/23, 20:42

  12. Oli Bartsch uploaded patch set 6 CR +1 V +1 02/10/23, 20:53

  13. Oli Bartsch voted on patch set 6 V +1 CR +1 02/10/23, 20:54

  14. Oli Bartsch uploaded patch set 7 CR +1 V +1 02/10/23, 20:57

  15. Oli Bartsch voted on patch set 7 V +1 CR +1 02/10/23, 20:58

  16. Benni Mack voted on patch set 7 V +1 CR +1 02/10/23, 20:58

  17. core-ci voted on patch set 5 V -1 02/10/23, 21:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37581

  18. core-ci voted on patch set 6 V -1 02/10/23, 21:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37584

  19. core-ci voted on patch set 7 V -1 02/10/23, 21:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37585

  20. Oli Bartsch uploaded patch set 8 CR +1 V +1 02/11/23, 12:26

  21. core-ci voted on patch set 8 V +1 02/11/23, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37607

  22. Oli Bartsch voted on patch set 8 V +1 CR +1 02/11/23, 16:07

  23. Josef Glatz voted on patch set 8 V +1 CR +1 02/11/23, 16:23

  24. Georg Ringer voted on patch set 8 V +2 CR +2 02/12/23, 11:41

  25. Georg Ringer merged patch set 9 02/12/23, 11:41