77827[TASK] Allow to use Locale object in PageRenderer
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Andreas Kienast +1
- Benjamin Kott +1
-
Verified V +2 Done
- Oli Bartsch +2
- Andreas Kienast +1
- Benjamin Kott +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Page/PageRenderer.php2+34 −10
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php+2 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+2 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+1 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/ImageContentObjectTest.php+1 −0
Review log 1422
-
Benni Mack uploaded patch set 1 02/10/23, 14:57
-
core-ci voted on patch set 1 V -1 02/10/23, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37570
-
Benni Mack rebased onto patch set 2
V -102/10/23, 20:52 -
core-ci voted on patch set 2 V -1 02/10/23, 21:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37583
-
Benni Mack commented on patch set 3
V -102/10/23, 21:15Published edit on patch set 2. -
Benni Mack uploaded patch set 4 02/10/23, 21:29
-
core-ci voted on patch set 3 V -1 02/10/23, 21:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37586
-
core-ci voted on patch set 4 V -1 02/10/23, 22:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37590
-
Benni Mack uploaded patch set 5
V -102/11/23, 09:42 -
core-ci voted on patch set 5 V -1 02/11/23, 10:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37603
-
Oli Bartsch commented on patch set 5 02/14/23, 11:54
PageRenderer.php:99Is nullable intended here? Constructor calls ->reset() which always initializes $local. The class itself does never set $local to null nor does any setter allow to set $local to null. So should we get rid of the nullable? -
Oli Bartsch uploaded patch set 6
V -102/17/23, 08:32 -
core-ci voted on patch set 6 V -1 02/17/23, 08:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37824
-
Oli Bartsch uploaded patch set 7
V -102/17/23, 09:29 -
core-ci voted on patch set 7 V -1 02/17/23, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37827
-
Oli Bartsch uploaded patch set 8
V -102/17/23, 10:27 -
core-ci voted on patch set 8 V +1 02/17/23, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37828
-
Oli Bartsch commented on patch set 8 V +1 CR +1 02/17/23, 10:47
PageRenderer.php:99ReplyDone -
Andreas Kienast voted on patch set 8 V +1 CR +1 02/17/23, 14:40
-
Benjamin Kott voted on patch set 8 V +1 CR +1 02/17/23, 14:40
-
Oli Bartsch voted on patch set 8 V +2 CR +2 02/17/23, 15:20
-
Oli Bartsch merged patch set 9 02/17/23, 15:20