Review main Merged

77827[TASK] Allow to use Locale object in PageRenderer

Benni Mack CR +2 V +2 Normal +40 −12 updated 02/17/23, 15:20

Commit message

This change uses the Locale object
and its internal normalization process
to automatically set the <html> tag
within the PageRenderer.

This change removes the usage of the
Typo3Language "default" in PageRenderer.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1422

  1. Benni Mack uploaded patch set 1 02/10/23, 14:57

  2. core-ci voted on patch set 1 V -1 02/10/23, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37570

  3. Benni Mack rebased onto patch set 2 V -1 02/10/23, 20:52

  4. core-ci voted on patch set 2 V -1 02/10/23, 21:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37583

  5. Benni Mack commented on patch set 3 V -1 02/10/23, 21:15

    Published edit on patch set 2.
  6. Benni Mack uploaded patch set 4 02/10/23, 21:29

  7. core-ci voted on patch set 3 V -1 02/10/23, 21:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37586

  8. core-ci voted on patch set 4 V -1 02/10/23, 22:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37590

  9. Benni Mack uploaded patch set 5 V -1 02/11/23, 09:42

  10. core-ci voted on patch set 5 V -1 02/11/23, 10:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37603

  11. Oli Bartsch commented on patch set 5 02/14/23, 11:54

    PageRenderer.php:99

    Is nullable intended here? Constructor calls ->reset() which always initializes $local. The class itself does never set $local to null nor does any setter allow to set $local to null. So should we get rid of the nullable?
  12. Oli Bartsch uploaded patch set 6 V -1 02/17/23, 08:32

  13. core-ci voted on patch set 6 V -1 02/17/23, 08:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37824

  14. Oli Bartsch uploaded patch set 7 V -1 02/17/23, 09:29

  15. core-ci voted on patch set 7 V -1 02/17/23, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37827

  16. Oli Bartsch uploaded patch set 8 V -1 02/17/23, 10:27

  17. core-ci voted on patch set 8 V +1 02/17/23, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37828

  18. Oli Bartsch commented on patch set 8 V +1 CR +1 02/17/23, 10:47

    PageRenderer.php:99 Reply

    Done
  19. Andreas Kienast voted on patch set 8 V +1 CR +1 02/17/23, 14:40

  20. Benjamin Kott voted on patch set 8 V +1 CR +1 02/17/23, 14:40

  21. Oli Bartsch voted on patch set 8 V +2 CR +2 02/17/23, 15:20

  22. Oli Bartsch merged patch set 9 02/17/23, 15:20