Review main Merged

77831[TASK] Deprecate PageRenderer->enableDebugMode()

Anja Leichsenring CR +2 V +2 Normal +55 −3 updated 02/14/23, 11:25

Commit message

PageRenderer->enableDebugMode() is only called in
backend by the core. The properties set by the
method do not have any effect in BE during further
processing.

The method is typically not called in Frontend,
any calls can be moved to the single setters
instead.

The patch deprecates PageRenderer->enableDebugMode().

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1013

  1. Anja Leichsenring uploaded patch set 1 02/12/23, 07:37

  2. core-ci voted on patch set 1 V +1 02/12/23, 07:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37617

  3. Christian Kuhn uploaded patch set 2 V +1 02/14/23, 10:47

  4. Christian Kuhn voted on patch set 2 V +1 CR +1 02/14/23, 10:51

  5. Georg Ringer commented on patch set 2 CR -1 02/14/23, 10:56

    MethodCallMatcher.php:5515

    should there be a \ or not?
  6. Anja Leichsenring commented on patch set 3 CR +1 V +1 02/14/23, 11:01

    Published edit on patch set 2.
  7. Anja Leichsenring commented on patch set 3 02/14/23, 11:01

    MethodCallMatcher.php:5515 Reply

    Done
  8. core-ci voted on patch set 2 V +1 02/14/23, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37676

  9. Christian Kuhn voted on patch set 3 V +1 CR +1 02/14/23, 11:07

  10. core-ci voted on patch set 3 V +1 02/14/23, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37678

  11. Georg Ringer voted on patch set 3 V +1 CR +1 02/14/23, 11:22

  12. Anja Leichsenring voted on patch set 3 V +2 CR +2 02/14/23, 11:25

  13. Anja Leichsenring merged patch set 4 02/14/23, 11:25