Review 11.5 Merged

77835[TASK] Use `list` as return type annotation for `GU::*Explode` methods

Christian Kuhn CR +2 V +2 Easy +2 −2 updated 02/13/23, 09:53

Commit message

The `GU::revExplode` and `GU::trimExplode` methods return lists of
elements. Thus, we can safely annotate them as `list` instead of `array`
to allow better static code analysis. The annotation for
`GU::intExplode` is not changed at the moment since this method behaves
differently.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Christian Kuhn uploaded patch set 1 02/13/23, 09:11

  2. core-ci voted on patch set 1 V +1 02/13/23, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37634

  3. Oliver Klee voted on patch set 1 V +1 CR +1 02/13/23, 09:35

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 02/13/23, 09:53

  5. Christian Kuhn merged patch set 2 02/13/23, 09:53