Review main Merged

77837[TASK] PhpStorm understands EventDispatcher->dispatch()

Andreas Kienast CR +2 V +2 Easy +4 −0 updated 02/13/23, 11:37

Commit message

PhpStorm now understands that PSR-14
`EventDispatcherInterface->dispatch()` returns an instance of the
first argument.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Andreas Kienast uploaded patch set 1 02/13/23, 11:18

  2. Andreas Kienast updated the commit message in patch set 2 02/13/23, 11:19

  3. Stefan Bürk voted on patch set 2 V +1 CR +1 02/13/23, 11:21

  4. Georg Ringer voted on patch set 2 V +1 CR +1 02/13/23, 11:22

  5. core-ci voted on patch set 2 V +1 02/13/23, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37638

  6. Andreas Kienast voted on patch set 2 V +2 CR +2 02/13/23, 11:28

  7. Andreas Kienast merged patch set 3 02/13/23, 11:28

  8. Christian Kuhn commented on patch set 3 02/13/23, 11:34

  9. core-ci voted on patch set 1 V +1 02/13/23, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37637