Review main Merged

77838[BUGFIX] Toolbar link to environment opens in iframe

Christian Kuhn CR +2 V +2 Easy +21 −27 updated 02/14/23, 10:59

Commit message

Toolbar > SystemInformation has a link to
Environment module that opens without module
menu and toolbar, just the main iframe.

Links from within the top iframe are managed
by JS and need some magic to trigger this
properly.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Jasmina Ließmann +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Jasmina Ließmann +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1315

  1. Christian Kuhn uploaded patch set 1 02/13/23, 11:31

  2. core-ci voted on patch set 1 V +1 02/13/23, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37639

  3. Jasmina Ließmann voted on patch set 1 V +1 CR +1 02/13/23, 13:28

  4. Georg Ringer commented on patch set 1 02/13/23, 13:40

    just as a FYI: this change won't work other languages as long as the translations are not adopted!
  5. Josef Glatz commented on patch set 1 CR -1 02/13/23, 14:01

    Please move HTML markup out of the language string. Unnecessarily complicated for translators if they have to deal with HTML markup in the translation UI
  6. Christian Kuhn commented on patch set 1 02/13/23, 15:30

    Reply

    how?
  7. Christian Kuhn uploaded patch set 2 CR +1 V +1 02/13/23, 17:40

  8. Christian Kuhn commented on patch set 2 02/13/23, 17:40

    Reply

    Done
  9. core-ci voted on patch set 2 V +1 02/13/23, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37660

  10. Stefan Bürk voted on patch set 2 V +1 CR +1 02/13/23, 18:11

  11. Jasmina Ließmann voted on patch set 2 V +1 CR +1 02/13/23, 18:15

  12. Stefan Bürk voted on patch set 2 V +2 CR +2 02/13/23, 18:28

  13. Stefan Bürk merged patch set 3 02/13/23, 18:28

  14. Benjamin Kott commented on patch set 3 02/14/23, 07:09

    _dropdown.scss:118

    Post -1, the component is based on css variables and this patch is reverting the effort put in making it adaptive for dark and light mode.
  15. Christian Kuhn commented on patch set 3 02/14/23, 10:59

    _dropdown.scss:118 Reply Unresolved

    Hey. You've now had 3 or 4 post -1 on patches in the toolbar. It seems nobody really gets the bigger picture you have in mind here. Maybe this part is a bit under-documented and communicated. I hope we'll be able to follow the plan you have in mind if more people understand this better and if this is documented in the sass files at appropriate places. Would you like to take care of this (again, sorry) for this case, and maybe improve code comments a bit at the same time to reduce the current communication penalty in this area?