Review main Merged

77842[TASK] Refine LiveSearch search demand

Andreas Kienast CR +2 V +2 Hard +390 −68 updated 02/14/23, 08:46

Commit message

The search demand implementation used by the LiveSearch is refined to be
more flexible. Instead of a hard-coded list of properties, the
constructor now receives a list of `DemandProperty` instances that
accept everything that is backed by the `DemandPropertyName` enum,
allowing to pass only the required properties.

The `SearchDemand` class is immutable by design, it's API must not
allow modification by 3rd parties. However, there is an internal
`MutableSearchDemand` acting as a helper that allows to add / override
properties. A `SearchDemand` object may be constructed from a request
object, where it's payload must contain properties from the
aforementioned `DemandPropertyName` enum.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 913

  1. Andreas Kienast uploaded patch set 1 02/13/23, 12:49

  2. core-ci voted on patch set 1 V +1 02/13/23, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37646

  3. Andreas Kienast uploaded patch set 2 V +1 02/13/23, 13:45

  4. core-ci voted on patch set 2 V +1 02/13/23, 13:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37650

  5. Andreas Kienast uploaded patch set 3 V +1 02/13/23, 15:23

  6. core-ci voted on patch set 3 V +1 02/13/23, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37653

  7. Georg Ringer voted on patch set 3 V +1 CR +1 02/13/23, 19:35

  8. Andreas Kienast rebased onto patch set 4 CR +1 V +1 02/14/23, 08:08

  9. Georg Ringer voted on patch set 4 V +1 CR +1 02/14/23, 08:09

  10. core-ci voted on patch set 4 V +1 02/14/23, 08:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37671

  11. Anja Leichsenring voted on patch set 4 V +1 CR +1 02/14/23, 08:40

  12. Andreas Kienast voted on patch set 4 V +2 CR +2 02/14/23, 08:46

  13. Andreas Kienast merged patch set 5 02/14/23, 08:46