77849[TASK] Move rename resource action to ajax
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 20
- Build/phpstan/phpstan-baseline.neon+0 −5
- Build/Sources/TypeScript/filelist/context-menu-actions.ts+13 −5
- Build/Sources/TypeScript/filelist/file-list-actions.ts+4 −0
- Build/Sources/TypeScript/filelist/file-list-rename-handler.ts8new+120 −0
- typo3/sysext/backend/Classes/Controller/Resource/ResourceController.php8new+142 −0
- typo3/sysext/backend/Configuration/Backend/AjaxRoutes.php+7 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_resource.xlf4new+31 −0
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+9 −0
- typo3/sysext/filelist/Classes/ContextMenu/ItemProviders/FileProvider.php+0 −3
- typo3/sysext/filelist/Classes/Controller/File/RenameFileController.phpdeleted+0 −208
- typo3/sysext/filelist/Classes/Controller/FileListController.php+1 −0
- typo3/sysext/filelist/Classes/Dto/ResourceView.php+9 −1
- typo3/sysext/filelist/Classes/FileList.php+3 −18
- typo3/sysext/filelist/Configuration/Backend/Routes.php+0 −6
- typo3/sysext/filelist/Resources/Private/Templates/File/RenameFile.htmldeleted+0 −40
- typo3/sysext/filelist/Resources/Public/JavaScript/context-menu-actions.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/file-list-actions.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/file-list-dragdrop.jsnew+13 −0
- typo3/sysext/filelist/Resources/Public/JavaScript/file-list-rename-handler.jsnew+17 −0
- typo3/sysext/filelist/Resources/Public/JavaScript/file-list-transfer-handler.jsnew+13 −0
Review log 2133
Show 48 earlier messages
-
Benjamin Kott uploaded patch set 1 02/14/23, 11:33
-
core-ci voted on patch set 1 V -1 02/14/23, 11:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37683
-
Benjamin Kott uploaded patch set 2
V -102/16/23, 15:09 -
core-ci voted on patch set 2 V -1 02/16/23, 16:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37810
-
Benjamin Kott uploaded patch set 3
V -102/17/23, 07:40 -
core-ci voted on patch set 3 V -1 02/17/23, 08:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37821
-
Benjamin Kott uploaded patch set 4
V -102/21/23, 08:50 -
core-ci voted on patch set 4 V -1 02/21/23, 09:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37917
-
Benjamin Kott uploaded patch set 5
V -102/21/23, 11:52 -
core-ci voted on patch set 5 V +1 02/21/23, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37920
-
Benjamin Kott uploaded patch set 6
V +102/21/23, 12:24 -
Benjamin Kott uploaded patch set 7 02/21/23, 12:28
-
core-ci voted on patch set 6 V -1 02/21/23, 12:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37921
-
core-ci voted on patch set 7 V +1 02/21/23, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37923
-
Benni Mack commented on patch set 7 V +1 CR +1 02/21/23, 13:41
We could improve the error handling in the future, while renaming. I tried renaming my jpg to a "myimage.php" file and the modal was gone, but I got a notication in the top right. -
Andreas Kienast uploaded patch set 8
CR +1V +102/22/23, 10:17 -
Christian Kuhn commented on patch set 8 02/22/23, 10:27
ResourceController.php:38please declare final and @internal. -
core-ci voted on patch set 8 V +1 02/22/23, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37963
-
Benjamin Kott uploaded patch set 9
V +102/23/23, 10:11 -
Benjamin Kott commented on patch set 9 02/23/23, 10:12
ResourceController.php:38ReplyDone -
core-ci voted on patch set 9 V +1 02/23/23, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38000
-
Andreas Kienast commented on patch set 9 CR -1 02/23/23, 10:38
file-list-rename-handler.ts:23Interface is unused, still required?file-list-rename-handler.ts:30Interface is unused, still required?file-list-rename-handler.ts:68form?.requestSubmit();file-list-rename-handler.ts:129You may add `required`, which is handled by `requestSubmit()`.ResourceController.php:76Could be converted to match(): ``` $message = match ($exception->getCode()) { 1676979120 => $this->getLanguageService()->sL('LLL:EXT:backend/Resources/Private/Language/locallang_resource.xlf:ajax.error.message.resourceNotFileOrFolder'), 1676299579 => $this->getLanguageService()->sL('LLL:EXT:backend/Resources/Private/Language/locallang_resource.xlf:ajax.error.message.resourceOutsideOfStorages'), 1676979130 => $this->getLanguageService()->sL('LLL:EXT:backend/Resources/Private/Language/locallang_resource.xlf:ajax.error.message.resourceNoPermissionRename'), 1676978732 => $this->getLanguageService()->sL('LLL:EXT:backend/Resources/Private/Language/locallang_resource.xlf:ajax.error.message.resourceNameCannotBeEmpty'), default => $exception->getMessage(), }; ```ResourceController.php:122returnlocallang_resource.xlf:7`resname` is missinglocallang_resource.xlf:13`resname` is missing -
Benni Mack commented on patch set 9 02/23/23, 14:23
ResourceController.php:55$identifier does not need to be a class member. method could be named "renameResourceAction" -
Benjamin Kott uploaded patch set 10
CR -1V +102/24/23, 09:17 -
Benjamin Kott uploaded patch set 11 02/24/23, 09:21
-
Benjamin Kott commented on patch set 11 02/24/23, 09:21
file-list-rename-handler.ts:23ReplyDonefile-list-rename-handler.ts:30ReplyDonefile-list-rename-handler.ts:68ReplyDonefile-list-rename-handler.ts:129ReplyDoneResourceController.php:55ReplyDoneResourceController.php:76ReplyDoneResourceController.php:122ReplyDonelocallang_resource.xlf:7ReplyDonelocallang_resource.xlf:13ReplyDone -
core-ci voted on patch set 11 V -1 02/24/23, 10:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38043
-
core-ci voted on patch set 10 V -1 02/24/23, 10:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38042
-
Benjamin Kott uploaded patch set 12
V -102/24/23, 10:33 -
core-ci voted on patch set 12 V +1 02/24/23, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38045
-
Benni Mack voted on patch set 12 V +1 CR +1 02/24/23, 13:20
-
Andreas Kienast voted on patch set 12 V +2 CR +2 02/24/23, 14:37
-
Andreas Kienast merged patch set 13 02/24/23, 14:37