77851[TASK] Introduce type declarations in extbase's Session class
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 5
- Build/phpstan/phpstan-baseline.neon+0 −15
- typo3/sysext/extbase/Classes/Persistence/Generic/PersistenceManager.php3+3 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Session.php26+27 −50
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/PersistenceManagerTest.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/SessionTest.php+33 −22
Review log 2937
Show 812 earlier messages
-
Alexander Schnitzler uploaded patch set 1 02/14/23, 12:33
-
Alexander Schnitzler marked it work in progress 02/14/23, 12:33
-
core-ci voted on patch set 1 V -1 02/14/23, 12:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37690
-
Oliver Klee commented on patch set 1 02/18/23, 14:47
-
Alexander Schnitzler uploaded patch set 2
V -103/02/23, 17:54 -
Alexander Schnitzler uploaded patch set 3 03/02/23, 18:08
-
core-ci voted on patch set 2 V -1 03/02/23, 18:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38318
-
Alexander Schnitzler uploaded patch set 4 03/02/23, 18:22
-
core-ci voted on patch set 3 V -1 03/02/23, 18:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38320
-
core-ci voted on patch set 4 V +1 03/02/23, 18:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38321
-
Oliver Klee commented on patch set 4 03/02/23, 19:04
Session.php:154ReplyDone -
Alexander Schnitzler wrote 03/03/23, 07:10
Topic set to extbase
-
Alexander Schnitzler updated the commit message in patch set 5
V +103/03/23, 07:11 -
Alexander Schnitzler commented on patch set 5 03/03/23, 07:11
This change is ready for review. -
core-ci voted on patch set 5 V +1 03/03/23, 07:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38337
-
Stefan Bürk commented on patch set 5 03/04/23, 13:03
PersistenceManager.php:139nitpick - please use `@todo` .. that make grepping more easier to have only one kind.Session.php:29superflous lineSession.php:33why not simply `@var` ?Session.php:98why is this changed from param to phpstan-param ?Session.php:152again .. why are all the annotation switch to phphstan prefixes ? why not staying on @return ? -
Alexander Schnitzler commented on patch set 5 03/04/23, 13:21
Session.php:152ReplyI tried to start a discussion a while ago here: https://decisions.typo3.org/t/phpstan-specific-phpdoc-annotations-in-the-core-code-base/807 To sum it up: A lot of changes towards phpstan specific syntax with regular phpdoc annotations break IDE support. non-empty-string e.g. adds information for phpstan but removes the former type information from tools that cannot read phpstan specific type-shapes. -
Stefan Froemken commented on patch set 5 CR +1 03/06/23, 18:27
PersistenceManager.php:139ReplyAt that position it is OK. But in case of Annotations I get something like todo is a non registered type for `@`. That's why I also have switched to just `ToDo` -
Oliver Klee voted on patch set 5 CR +1 03/06/23, 18:43
-
Alexander Schnitzler uploaded patch set 6
CR +1V +103/08/23, 14:21 -
Alexander Schnitzler uploaded patch set 7 03/08/23, 14:23
-
Alexander Schnitzler commented on patch set 7 03/08/23, 14:24
PersistenceManager.php:139ReplyDoneSession.php:29ReplyDoneSession.php:33ReplyDoneSession.php:98ReplyDoneSession.php:152ReplyDone -
Oliver Klee voted on patch set 7 V +1 CR +1 03/08/23, 14:26
-
core-ci voted on patch set 7 V +1 03/08/23, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38656
-
core-ci voted on patch set 6 V +1 03/08/23, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38655
-
Nikita Hovratov commented on patch set 7 03/08/23, 15:13
Session.php:97Shouldn't this be phpstan-param too?Session.php:151Shouldn't this be phpstan-param too? -
Oliver Klee commented on patch set 7 03/08/23, 15:21
Session.php:97ReplyNo, as the point of the @phpstan-* annotations is to have another source of information in addition to something that IDEs like PHPStan are known to understand. In this case, we already have the native type declaration for the parameter, and so the IDEs are covered. :-)Session.php:151ReplyThis is the same as for the parameter. -
Nikita Hovratov commented on patch set 7 03/08/23, 15:23
Session.php:87Thanks Oliver! So this can be a normal @param then? -
Oliver Klee commented on patch set 7 03/08/23, 15:41
Session.php:87ReplyYes. -
Oliver Klee commented on patch set 7 CR 0 03/08/23, 18:14
Session.php:32Can/should some of these `string`s be `non-empty-string` or `class-string`?Session.php:99`@param non-empty-string $identifier`Session.php:108`@return non-empty-string|null`, I guess.Session.php:119`@param non-empty-string $identifier` -
Oliver Klee commented on patch set 7 CR -1 03/10/23, 15:01
On it. -
Oliver Klee commented on patch set 7 03/10/23, 15:06
Session.php:32ReplyDoneSession.php:87ReplyDoneSession.php:99ReplyDoneSession.php:108ReplyDoneSession.php:119ReplyDone -
Oliver Klee uploaded patch set 8
CR -1V +103/10/23, 15:06 -
Oliver Klee voted on patch set 8 V +1 CR +1 03/10/23, 15:07
-
core-ci voted on patch set 8 V +1 03/10/23, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38776
-
Benni Mack voted on patch set 8 V +2 CR +2 03/10/23, 15:24
-
Benni Mack merged patch set 9 03/10/23, 15:24
Session.php:154