Review main Merged

77851[TASK] Introduce type declarations in extbase's Session class

Alexander Schnitzler CR +2 V +2 Normal +66 −90 updated 03/10/23, 15:24

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 2937

Show 812 earlier messages
  1. Alexander Schnitzler uploaded patch set 1 02/14/23, 12:33

  2. Alexander Schnitzler marked it work in progress 02/14/23, 12:33

  3. core-ci voted on patch set 1 V -1 02/14/23, 12:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37690

  4. Oliver Klee commented on patch set 1 02/18/23, 14:47

    Session.php:154

    @return non-empty-string
  5. Alexander Schnitzler uploaded patch set 2 V -1 03/02/23, 17:54

  6. Alexander Schnitzler uploaded patch set 3 03/02/23, 18:08

  7. core-ci voted on patch set 2 V -1 03/02/23, 18:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38318

  8. Alexander Schnitzler uploaded patch set 4 03/02/23, 18:22

  9. core-ci voted on patch set 3 V -1 03/02/23, 18:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38320

  10. core-ci voted on patch set 4 V +1 03/02/23, 18:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38321

  11. Oliver Klee commented on patch set 4 03/02/23, 19:04

    Session.php:154 Reply

    Done
  12. Alexander Schnitzler wrote 03/03/23, 07:10

    Topic set to extbase
  1. Alexander Schnitzler updated the commit message in patch set 5 V +1 03/03/23, 07:11

  2. Alexander Schnitzler commented on patch set 5 03/03/23, 07:11

    This change is ready for review.
  3. core-ci voted on patch set 5 V +1 03/03/23, 07:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38337

  4. Stefan Bürk commented on patch set 5 03/04/23, 13:03

    PersistenceManager.php:139

    nitpick - please use `@todo` .. that make grepping more easier to have only one kind.

    Session.php:29

    superflous line

    Session.php:33

    why not simply `@var` ?

    Session.php:98

    why is this changed from param to phpstan-param ?

    Session.php:152

    again .. why are all the annotation switch to phphstan prefixes ? why not staying on @return ?
  5. Alexander Schnitzler commented on patch set 5 03/04/23, 13:21

    Session.php:152 Reply

    I tried to start a discussion a while ago here: https://decisions.typo3.org/t/phpstan-specific-phpdoc-annotations-in-the-core-code-base/807 To sum it up: A lot of changes towards phpstan specific syntax with regular phpdoc annotations break IDE support. non-empty-string e.g. adds information for phpstan but removes the former type information from tools that cannot read phpstan specific type-shapes.
  6. Stefan Froemken commented on patch set 5 CR +1 03/06/23, 18:27

    PersistenceManager.php:139 Reply

    At that position it is OK. But in case of Annotations I get something like todo is a non registered type for `@`. That's why I also have switched to just `ToDo`
  7. Oliver Klee voted on patch set 5 CR +1 03/06/23, 18:43

  8. Alexander Schnitzler uploaded patch set 6 CR +1 V +1 03/08/23, 14:21

  9. Alexander Schnitzler uploaded patch set 7 03/08/23, 14:23

  10. Alexander Schnitzler commented on patch set 7 03/08/23, 14:24

    PersistenceManager.php:139 Reply

    Done

    Session.php:29 Reply

    Done

    Session.php:33 Reply

    Done

    Session.php:98 Reply

    Done

    Session.php:152 Reply

    Done
  11. Oliver Klee voted on patch set 7 V +1 CR +1 03/08/23, 14:26

  12. core-ci voted on patch set 7 V +1 03/08/23, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38656

  13. core-ci voted on patch set 6 V +1 03/08/23, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38655

  14. Nikita Hovratov commented on patch set 7 03/08/23, 15:13

    Session.php:97

    Shouldn't this be phpstan-param too?

    Session.php:151

    Shouldn't this be phpstan-param too?
  15. Oliver Klee commented on patch set 7 03/08/23, 15:21

    Session.php:97 Reply

    No, as the point of the @phpstan-* annotations is to have another source of information in addition to something that IDEs like PHPStan are known to understand. In this case, we already have the native type declaration for the parameter, and so the IDEs are covered. :-)

    Session.php:151 Reply

    This is the same as for the parameter.
  16. Nikita Hovratov commented on patch set 7 03/08/23, 15:23

    Session.php:87

    Thanks Oliver! So this can be a normal @param then?
  17. Oliver Klee commented on patch set 7 03/08/23, 15:41

    Session.php:87 Reply

    Yes.
  18. Oliver Klee commented on patch set 7 CR 0 03/08/23, 18:14

    Session.php:32

    Can/should some of these `string`s be `non-empty-string` or `class-string`?

    Session.php:99

    `@param non-empty-string $identifier`

    Session.php:108

    `@return non-empty-string|null`, I guess.

    Session.php:119

    `@param non-empty-string $identifier`
  19. Oliver Klee commented on patch set 7 CR -1 03/10/23, 15:01

    On it.
  20. Oliver Klee commented on patch set 7 03/10/23, 15:06

    Session.php:32 Reply

    Done

    Session.php:87 Reply

    Done

    Session.php:99 Reply

    Done

    Session.php:108 Reply

    Done

    Session.php:119 Reply

    Done
  21. Oliver Klee uploaded patch set 8 CR -1 V +1 03/10/23, 15:06

  22. Oliver Klee voted on patch set 8 V +1 CR +1 03/10/23, 15:07

  23. core-ci voted on patch set 8 V +1 03/10/23, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38776

  24. Benni Mack voted on patch set 8 V +2 CR +2 03/10/23, 15:24

  25. Benni Mack merged patch set 9 03/10/23, 15:24