Review main Merged

77852[TASK] Avoid GU::_GP() in PageTsBackendLayoutDataProvider

Christian Kuhn CR +2 V +2 Normal +35 −99 updated 02/15/23, 11:29

Commit message

The method using GU::_GP() can get more data
hand over to always have the pageId available
already. Do this and avoid another call to
GeneralUtility::_GP().

Note the entire backend layout handling carries
far too much state, is complex in general and
hard to follow. It should be streamlined and
simplified.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Christian Kuhn uploaded patch set 1 02/14/23, 13:44

  2. core-ci voted on patch set 1 V +1 02/14/23, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37692

  3. Stefan Bürk voted on patch set 1 CR +1 02/14/23, 14:03

  4. Stefan Bürk voted on patch set 1 V +1 02/14/23, 15:53

  5. Andreas Kienast voted on patch set 1 V +1 CR +1 02/15/23, 11:26

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 02/15/23, 11:29

  7. Christian Kuhn merged patch set 2 02/15/23, 11:29