Review main Merged

77855[TASK] Streamline module link handling

Benjamin Kott CR +2 V +2 Hard +368 −345 updated 02/16/23, 18:56

Commit message

This patch scopes the handling of module links within the module menu
and toolbar. We are now differentiating between module menu events and
module link events and avoiding the double usage of data attributes to
have the scope of the data-attributes assigned.

The internal selectors are now using on data-attributes, this provides
various benefits in contrast to legacy `t3js-...` class based selectors.

- Attributes can contain additional values we need for processing
- We avoid conflicts with for example `*:not([class])` CSS selectors,
  this is helpful to identify links that need special treatment for
  example color adjustments within adaptive components like the
  dropdowns.

While the module menu in its current state still handles the module
links, this patch prepares future work to extract the link management.
Managing the module links in the backend should not be the
responsibility of the module menu.

We are removing all "id" attributes attached to links to avoid conflicts
with other existing identifiers in the backend. The processing has
been adjusted to support this change.

The keyboard navigation is now simplified and adjusted when leaving a
subgroup the selection is now correctly at the parent element and not
the previous parent element.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 25

Show 5 more files

Review log 1832

Show 47 earlier messages
  1. Benjamin Kott uploaded patch set 1 02/14/23, 17:29

  2. core-ci voted on patch set 1 V -1 02/14/23, 17:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37705

  3. Benjamin Kott uploaded patch set 2 V -1 02/15/23, 13:50

  4. Benjamin Kott uploaded patch set 3 02/15/23, 14:17

  5. core-ci voted on patch set 2 V -1 02/15/23, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37752

  6. Benjamin Kott uploaded patch set 4 02/15/23, 14:33

  7. core-ci voted on patch set 3 V -1 02/15/23, 14:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37756

  1. Benjamin Kott uploaded patch set 5 02/15/23, 15:10

  2. core-ci voted on patch set 4 V -1 02/15/23, 15:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37758

  3. Benjamin Kott uploaded patch set 6 02/15/23, 15:31

  4. core-ci voted on patch set 5 V -1 02/15/23, 15:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37760

  5. core-ci voted on patch set 6 V -1 02/15/23, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37763

  6. Benjamin Kott uploaded patch set 7 V -1 02/15/23, 15:59

  7. core-ci voted on patch set 7 V -1 02/15/23, 16:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37769

  8. Benjamin Kott uploaded patch set 8 V -1 02/16/23, 13:23

  9. Benjamin Kott uploaded patch set 9 02/16/23, 13:25

  10. core-ci voted on patch set 8 V -1 02/16/23, 13:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37796

  11. core-ci voted on patch set 9 V -1 02/16/23, 13:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37797

  12. Benjamin Kott uploaded patch set 10 V -1 02/16/23, 13:46

  13. core-ci voted on patch set 10 V +1 02/16/23, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37802

  14. Benjamin Kott uploaded patch set 11 V +1 02/16/23, 14:25

  15. Benjamin Kott uploaded patch set 12 02/16/23, 14:27

  16. Andreas Kienast updated the commit message in patch set 13 02/16/23, 14:37

  17. core-ci voted on patch set 11 V +1 02/16/23, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37805

  18. core-ci voted on patch set 12 V +1 02/16/23, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37806

  19. core-ci voted on patch set 13 V +1 02/16/23, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37807

  20. Andreas Kienast uploaded patch set 14 V +1 02/16/23, 14:56

  21. Andreas Kienast voted on patch set 14 V +1 02/16/23, 14:59

  22. core-ci voted on patch set 14 V +1 02/16/23, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37809

  23. Anja Leichsenring voted on patch set 14 V +1 CR +1 02/16/23, 18:41

  24. Stefan Bürk voted on patch set 14 V +2 CR +2 02/16/23, 18:56

  25. Stefan Bürk merged patch set 15 02/16/23, 18:56