Review main Merged

77856[TASK] Avoid GU::_GP() in DataHandler

Christian Kuhn CR +2 V +2 Hard +112 −222 updated 02/15/23, 12:05

Commit message

DataHandler should of course *not* have a dependency
to _GET or _POST: All data should be hand over as
"command" and "data" array.

Flex form handling violates this for section container
deletion and sorting by using GeneralUtility::_GP().

The patch changes the logic to carry the "_ACTION"
information within the flex data array. This simplifies
the flex form handling logic a bit, we can get rid
of a recursion along the way.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 913

  1. Christian Kuhn uploaded patch set 1 02/14/23, 17:56

  2. Christian Kuhn uploaded patch set 2 02/14/23, 18:18

  3. core-ci voted on patch set 1 V -1 02/14/23, 18:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37709

  4. core-ci voted on patch set 2 V -1 02/14/23, 19:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37710

  5. Christian Kuhn uploaded patch set 3 V -1 02/15/23, 08:43

  6. core-ci voted on patch set 3 V -1 02/15/23, 09:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37730

  7. Christian Kuhn uploaded patch set 4 V -1 02/15/23, 10:57

  8. core-ci voted on patch set 4 V +1 02/15/23, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37735

  9. Andreas Kienast voted on patch set 4 V +1 CR +1 02/15/23, 11:19

  10. Stefan Bürk commented on patch set 4 CR -1 02/15/23, 11:32

    testing ...
  11. Stefan Bürk voted on patch set 4 V +1 CR +1 02/15/23, 11:39

  12. Christian Kuhn voted on patch set 4 V +2 CR +2 02/15/23, 12:05

  13. Christian Kuhn merged patch set 5 02/15/23, 12:05