77860[BUGFIX] Add type cast for potential mountpoint information
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Stefan Bürk +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1520
-
Georg Ringer uploaded patch set 1 02/15/23, 08:42
-
Georg Ringer commented on patch set 1 02/15/23, 08:42
This change is ready for review. -
Thomas Hohn updated the commit message in patch set 2 02/15/23, 08:44
-
Thomas Hohn voted on patch set 2 CR +1 02/15/23, 08:44
-
core-ci voted on patch set 1 V +1 02/15/23, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37729
-
core-ci voted on patch set 2 V +1 02/15/23, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37731
-
Stefan Bürk updated the commit message in patch set 3
CR +1V +102/15/23, 09:28 -
Stefan Bürk commented on patch set 3 V +1 CR +1 02/15/23, 09:29
RootlineUtility.php:106v11 backport we need a string cast here then ... -
core-ci voted on patch set 3 V +1 02/15/23, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37733
-
Oli Bartsch commented on patch set 3 02/15/23, 12:43
RootlineUtility.php:376Since this is type hinted string, let's avoid magic empty() here and just use a strict check. -
Oli Bartsch uploaded patch set 4
CR +1V +102/15/23, 12:49 -
Oli Bartsch commented on patch set 4 V +1 CR +1 02/15/23, 12:52
RootlineUtility.php:106ReplyDoneRootlineUtility.php:376ReplyDone -
core-ci voted on patch set 4 V +1 02/15/23, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37743
-
Oli Bartsch uploaded patch set 5
CR +1V +102/15/23, 13:14 -
Oli Bartsch voted on patch set 5 V +1 CR +1 02/15/23, 13:15
-
core-ci voted on patch set 5 V +1 02/15/23, 13:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37749
-
Stefan Bürk voted on patch set 5 V +1 CR +1 02/15/23, 15:43
-
Jochen Roth voted on patch set 5 V +1 CR +1 02/15/23, 15:45
-
Oli Bartsch voted on patch set 5 V +2 CR +2 02/15/23, 15:59
-
Oli Bartsch merged patch set 6 02/15/23, 15:59