Review main Merged

77860[BUGFIX] Add type cast for potential mountpoint information

Georg Ringer CR +2 V +2 Easy +5 −1 updated 02/15/23, 15:59

Commit message

Avoid exceptions by adding a type cast to string for the mount point
information. An additional early return avoids additional calls to
`\TYPO3\CMS\Core\Utility\GeneralUtility::trimExplode()`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1520

  1. Georg Ringer uploaded patch set 1 02/15/23, 08:42

  2. Georg Ringer commented on patch set 1 02/15/23, 08:42

    This change is ready for review.
  3. Thomas Hohn updated the commit message in patch set 2 02/15/23, 08:44

  4. Thomas Hohn voted on patch set 2 CR +1 02/15/23, 08:44

  5. core-ci voted on patch set 1 V +1 02/15/23, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37729

  6. core-ci voted on patch set 2 V +1 02/15/23, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37731

  7. Stefan Bürk updated the commit message in patch set 3 CR +1 V +1 02/15/23, 09:28

  8. Stefan Bürk commented on patch set 3 V +1 CR +1 02/15/23, 09:29

    RootlineUtility.php:106

    v11 backport we need a string cast here then ...
  9. core-ci voted on patch set 3 V +1 02/15/23, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37733

  10. Oli Bartsch commented on patch set 3 02/15/23, 12:43

    RootlineUtility.php:376

    Since this is type hinted string, let's avoid magic empty() here and just use a strict check.
  11. Oli Bartsch uploaded patch set 4 CR +1 V +1 02/15/23, 12:49

  12. Oli Bartsch commented on patch set 4 V +1 CR +1 02/15/23, 12:52

    RootlineUtility.php:106 Reply

    Done

    RootlineUtility.php:376 Reply

    Done
  13. core-ci voted on patch set 4 V +1 02/15/23, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37743

  14. Oli Bartsch uploaded patch set 5 CR +1 V +1 02/15/23, 13:14

  15. Oli Bartsch voted on patch set 5 V +1 CR +1 02/15/23, 13:15

  16. core-ci voted on patch set 5 V +1 02/15/23, 13:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37749

  17. Stefan Bürk voted on patch set 5 V +1 CR +1 02/15/23, 15:43

  18. Jochen Roth voted on patch set 5 V +1 CR +1 02/15/23, 15:45

  19. Oli Bartsch voted on patch set 5 V +2 CR +2 02/15/23, 15:59

  20. Oli Bartsch merged patch set 6 02/15/23, 15:59