Review main Merged

77866[BUGFIX] Remove hardcoded link colors from dropdown

Benjamin Kott CR +2 V +2 Normal +26 −26 updated 02/17/23, 06:27

Commit message

The dropdown component is completly based on
css variables, this patch removes hardcoded colors.

We are introducing a new link color css variable
that can be used for general link styling within
adaptive components.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 1014

  1. Benjamin Kott uploaded patch set 1 02/15/23, 14:14

  2. Benjamin Kott commented on patch set 1 CR -1 02/15/23, 14:14

    needs prepatch
  3. Benjamin Kott updated the commit message in patch set 2 CR -1 02/15/23, 14:15

  4. Benjamin Kott commented on patch set 2 CR -1 02/15/23, 14:15

    still needs prepatch
  5. core-ci voted on patch set 1 V +1 02/15/23, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37754

  6. core-ci voted on patch set 2 V +1 02/15/23, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37755

  7. Benjamin Kott uploaded patch set 3 CR -1 V +1 02/16/23, 14:54

  8. Benjamin Kott commented on patch set 3 02/16/23, 14:55

    Needs the following patch to go in first 77855: [TASK] Streamline module link handling | https://review.typo3.org/c/Packages/TYPO3.CMS/+/77855
  9. core-ci voted on patch set 3 V +1 02/16/23, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37808

  10. Anja Leichsenring rebased onto patch set 4 V +1 02/16/23, 19:10

  11. core-ci voted on patch set 4 V +1 02/16/23, 19:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37814

  12. Anja Leichsenring commented on patch set 3 V +1 CR +1 02/16/23, 19:26

    prepatch has been merged
  13. Georg Ringer voted on patch set 4 V +2 CR +2 02/17/23, 06:27

  14. Georg Ringer merged patch set 5 02/17/23, 06:27