77870[TASK] Clean up Expression Language Resolver class
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
-
Verified V +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1113
-
Christian Kuhn uploaded patch set 1 02/15/23, 15:44
-
Christian Kuhn voted on patch set 1 V +1 CR +1 02/15/23, 15:45
-
Stefan Bürk voted on patch set 1 V +1 CR +1 02/15/23, 15:49
-
core-ci voted on patch set 1 V -1 02/15/23, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37764
-
Oli Bartsch commented on patch set 1 02/15/23, 16:08
-
Stefan Bürk voted on patch set 1 V 0 CR 0 02/15/23, 17:58
-
Christian Kuhn uploaded patch set 2
CR +1V +102/16/23, 08:44 -
Christian Kuhn commented on patch set 2 02/16/23, 08:45
Resolver.php:30ReplyDone -
core-ci voted on patch set 2 V +1 02/16/23, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37790
-
Stefan Bürk voted on patch set 2 V +1 CR +1 02/16/23, 08:51
-
Anja Leichsenring commented on patch set 2 02/16/23, 09:52
Resolver.php:30will that work without value initialization? Unsure, we saw errors in similar situations. -
Oli Bartsch commented on patch set 2 V +2 CR +2 02/16/23, 09:54
Resolver.php:30ReplyPlease see my comment from above. -
Oli Bartsch merged patch set 3 02/16/23, 09:54
Resolver.php:30