Review main Merged

77878[TASK] LiveSearch: Render link to record list for database records

Andreas Kienast CR +2 V +2 Normal +40 −14 updated 08/05/23, 20:19

Commit message

For results of the LiveSearch's `DatabaseRecordProvider` a new "Show
record list" button is added to open the page where a record is stored
in the record list.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2026

Show 1 earlier messages
  1. Andreas Kienast uploaded patch set 1 02/16/23, 11:17

  1. core-ci voted on patch set 1 V -1 02/16/23, 12:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37793

  2. core-ci commented on patch set 1 02/16/23, 12:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37793

  3. Andreas Kienast uploaded patch set 2 V -1 02/16/23, 13:43

  4. core-ci voted on patch set 2 V +1 02/16/23, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37801

  5. Guido Schmechel commented on patch set 2 02/16/23, 14:24

    DatabaseRecordProvider.php:377

    Shouldn't $tableName be used here? It would also have to be passed into the function. Or am I misunderstanding something?
  6. Andreas Kienast commented on patch set 2 02/16/23, 14:26

    DatabaseRecordProvider.php:377 Reply

    No. You always open a page in the record list ;)
  7. Guido Schmechel commented on patch set 2 02/16/23, 14:30

    DatabaseRecordProvider.php:377 Reply

    Ah okay. I was wondering here if you can see a news entry, for example, even if it goes to the pages list view.
  8. Anja Leichsenring voted on patch set 2 V +1 CR +1 02/16/23, 19:32

  9. Anja Leichsenring commented on patch set 2 02/16/23, 19:33

    just for understanding: this will only apply to the flyout of the liveSearch, not on the result page when one clicks the "show all" option, right?
  10. Anja Leichsenring commented on patch set 2 02/16/23, 19:35

    Reply

    oh, forget it. Show all opens a list module.
  11. Oli Bartsch commented on patch set 2 02/16/23, 20:37

    DatabaseRecordProvider.php:362

    The whole PHPDoc needs some adjustment

    DatabaseRecordProvider.php:376

    Do we need to check for ['ctrl']['hideTable'] as well?

    DatabaseRecordProvider.php:422

    Shouldn't this be: BackendUtility::readPageAccess($row['pid'], $this->getBackendUser()->getPagePermsClause(Permission::PAGE_SHOW)) ?
  12. Andreas Kienast commented on patch set 2 CR -1 02/17/23, 11:36

    DatabaseRecordProvider.php:362 Reply

    Ack

    DatabaseRecordProvider.php:376 Reply

    I don't think so, wh should somebody hide the "pages" table?

    DatabaseRecordProvider.php:422 Reply

    That's just copied from PageRecordProvider, and IIRC this is already used in the old search.
  13. Andreas Kienast uploaded patch set 3 CR +1 V +1 02/17/23, 12:25

  14. core-ci voted on patch set 3 V +1 02/17/23, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37830

  15. Guido Schmechel voted on patch set 3 V +1 CR +1 02/20/23, 13:29

  16. Andreas Kienast rebased onto patch set 4 CR +1 V +1 08/03/23, 18:57

  17. Jörg Bösche voted on patch set 4 V +1 CR +1 08/03/23, 19:11

  18. core-ci voted on patch set 4 V -1 08/03/23, 19:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44944

  19. Andreas Kienast uploaded patch set 5 CR +1 V +1 08/03/23, 21:44

  20. core-ci voted on patch set 5 V +1 08/03/23, 21:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44999

  21. Anja Leichsenring voted on patch set 5 V +1 CR +1 08/04/23, 07:53

  22. Christian Kuhn commented on patch set 5 08/05/23, 20:17

    DatabaseRecordProvider.php:422 Reply

    Done
  23. Christian Kuhn commented on patch set 5 V +1 CR +1 08/05/23, 20:19

    DatabaseRecordProvider.php:376 Reply

    Done
  24. Andreas Kienast voted on patch set 5 V +2 CR +2 08/05/23, 20:19

  25. Andreas Kienast merged patch set 6 08/05/23, 20:19