77878[TASK] LiveSearch: Render link to record list for database records
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Anja Leichsenring +1
- Christian Kuhn +1
-
Verified V +2 Done
- Andreas Kienast +2
- Anja Leichsenring +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 3
Review log 2026
Show 1 earlier messages
-
Andreas Kienast uploaded patch set 1 02/16/23, 11:17
-
core-ci voted on patch set 1 V -1 02/16/23, 12:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37793
-
core-ci commented on patch set 1 02/16/23, 12:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37793
-
Andreas Kienast uploaded patch set 2
V -102/16/23, 13:43 -
core-ci voted on patch set 2 V +1 02/16/23, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37801
-
Guido Schmechel commented on patch set 2 02/16/23, 14:24
-
Andreas Kienast commented on patch set 2 02/16/23, 14:26
DatabaseRecordProvider.php:377ReplyNo. You always open a page in the record list ;) -
Guido Schmechel commented on patch set 2 02/16/23, 14:30
DatabaseRecordProvider.php:377ReplyAh okay. I was wondering here if you can see a news entry, for example, even if it goes to the pages list view. -
Anja Leichsenring voted on patch set 2 V +1 CR +1 02/16/23, 19:32
-
Anja Leichsenring commented on patch set 2 02/16/23, 19:33
just for understanding: this will only apply to the flyout of the liveSearch, not on the result page when one clicks the "show all" option, right? -
Anja Leichsenring commented on patch set 2 02/16/23, 19:35
Reply
oh, forget it. Show all opens a list module. -
Oli Bartsch commented on patch set 2 02/16/23, 20:37
DatabaseRecordProvider.php:362The whole PHPDoc needs some adjustmentDatabaseRecordProvider.php:376Do we need to check for ['ctrl']['hideTable'] as well?DatabaseRecordProvider.php:422Shouldn't this be: BackendUtility::readPageAccess($row['pid'], $this->getBackendUser()->getPagePermsClause(Permission::PAGE_SHOW)) ? -
Andreas Kienast commented on patch set 2 CR -1 02/17/23, 11:36
DatabaseRecordProvider.php:362ReplyAckDatabaseRecordProvider.php:376ReplyI don't think so, wh should somebody hide the "pages" table?DatabaseRecordProvider.php:422ReplyThat's just copied from PageRecordProvider, and IIRC this is already used in the old search. -
Andreas Kienast uploaded patch set 3
CR +1V +102/17/23, 12:25 -
core-ci voted on patch set 3 V +1 02/17/23, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37830
-
Guido Schmechel voted on patch set 3 V +1 CR +1 02/20/23, 13:29
-
Andreas Kienast rebased onto patch set 4
CR +1V +108/03/23, 18:57 -
Jörg Bösche voted on patch set 4 V +1 CR +1 08/03/23, 19:11
-
core-ci voted on patch set 4 V -1 08/03/23, 19:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44944
-
Andreas Kienast uploaded patch set 5
CR +1V +108/03/23, 21:44 -
core-ci voted on patch set 5 V +1 08/03/23, 21:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44999
-
Anja Leichsenring voted on patch set 5 V +1 CR +1 08/04/23, 07:53
-
Christian Kuhn commented on patch set 5 08/05/23, 20:17
DatabaseRecordProvider.php:422ReplyDone -
Christian Kuhn commented on patch set 5 V +1 CR +1 08/05/23, 20:19
DatabaseRecordProvider.php:376ReplyDone -
Andreas Kienast voted on patch set 5 V +2 CR +2 08/05/23, 20:19
-
Andreas Kienast merged patch set 6 08/05/23, 20:19
DatabaseRecordProvider.php:377