Review main Merged

77881[BUGFIX] Properly encode context menu URL parameters

Oli Bartsch CR +2 V +2 Easy +3 −3 updated 02/16/23, 19:36

Commit message

Especially the "uid" might contain special characters as
it holds the combined identifier in case of e.g. folders.
Encoding this value is therefore necessary to prevent
JS errors on executing the corresponding AJAX request.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Oli Bartsch uploaded patch set 1 02/16/23, 13:34

  2. Oli Bartsch updated the commit message in patch set 2 02/16/23, 13:37

  3. core-ci voted on patch set 2 V +1 02/16/23, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37800

  4. core-ci voted on patch set 1 V +1 02/16/23, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37799

  5. Andreas Kienast voted on patch set 2 V +1 CR +1 02/16/23, 13:51

  6. Anja Leichsenring voted on patch set 2 V +2 CR +2 02/16/23, 19:36

  7. Anja Leichsenring merged patch set 3 02/16/23, 19:36