Review main Merged

77882[BUGFIX] Do not swallow `pointerdown` event in finisher configuration

Andreas Kienast CR +2 V +2 Easy +1 −0 updated 02/16/23, 15:03

Commit message

With #98604, jQuery UI was replaced with SortableJS. It turns out that
filtered element, where dragging should be disabled, also calls
`preventDefault()` by default, leading to the issue that text fields
cannot get focused anymore.

As documented by SortableJS, `preventOnFilter` is now set to `false` to
allow editing text fields again whilst disabling dragging their parent
container.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 45

  1. Andreas Kienast uploaded patch set 1 02/16/23, 14:10

  2. core-ci voted on patch set 1 V +1 02/16/23, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37803

  3. Georg Ringer voted on patch set 1 V +1 CR +1 02/16/23, 14:30

  4. Oli Bartsch voted on patch set 1 V +2 CR +2 02/16/23, 15:02

  5. Oli Bartsch merged patch set 2 02/16/23, 15:03