Review main Merged

77892[BUGFIX] Streamline table appearance in the backend

Benjamin Kott CR +2 V +2 Nightmare +1569 −1546 updated 02/23/23, 14:21

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 46

Show 26 more files

Review log 1621

  1. Benjamin Kott uploaded patch set 1 02/17/23, 14:00

  2. core-ci voted on patch set 1 V +1 02/17/23, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37839

  3. Benjamin Kott uploaded patch set 2 V +1 02/17/23, 14:22

  4. Benjamin Kott uploaded patch set 3 02/17/23, 14:26

  5. core-ci voted on patch set 2 V +1 02/17/23, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37841

  6. Benjamin Kott uploaded patch set 4 02/17/23, 14:30

  7. Andreas Kienast voted on patch set 4 V +1 CR +1 02/17/23, 14:32

  8. core-ci voted on patch set 4 V +1 02/17/23, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37843

  9. core-ci voted on patch set 3 V +1 02/17/23, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37842

  10. Jasmina Ließmann commented on patch set 4 02/17/23, 18:49

    Overview.html:84

    I'd prefer if no context menu is built in. It contains too many options that are not helpful at this point. E.g. create, cut, copy and paste pages, history.
  11. Benjamin Kott commented on patch set 4 02/17/23, 19:38

    Overview.html:84 Reply

    well, at some points i agree but you have no option here to jump into the site to enable it for example.
  12. Jasmina Ließmann commented on patch set 4 02/17/23, 19:52

    Overview.html:84 Reply

    I understand. I assume there is no ways to limit the available options in context menu? For me the only relevant options at this place are 'enable' / 'disable' and 'delete'. Imho pages are mainly maintained in page or list module. I would expect the developer/integrator to switch to one of these modules for these two actions. Even though I understand your point of easier maintenance by adding the context menu here.
  13. Benjamin Kott commented on patch set 4 02/18/23, 10:15

    Overview.html:84 Reply

    Currently the contextmenu is a hardcoded list of actions, per record table - there are some additional checks for the record it self but its the same through the backend. For the current state most of the icons in the backend have context menus. This was a decision years ago to ensure, even before my time. We kept this to ensure users expectations are matched. I am open vor having this changed, but having to find the page in the pagetree again or cannot enter the edit mode from the sites module seems to be wrong for me.
  14. Benjamin Kott commented on patch set 4 02/18/23, 10:15

    Overview.html:84 Reply

    Aside from that the whole view news an overhaul, but that is a different task for another day.
  15. Benni Mack commented on patch set 4 V +1 CR +1 02/21/23, 11:07

    Overview.html:84 Reply

    I think we should keep it in, and then take another round on the context menu again to streamline this.
  16. Benjamin Kott uploaded patch set 5 CR +1 V +1 02/23/23, 10:02

  17. Andreas Kienast voted on patch set 5 V +1 CR +1 02/23/23, 10:03

  18. core-ci voted on patch set 5 V +1 02/23/23, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37999

  19. Stefan Bürk voted on patch set 5 V +1 CR +1 02/23/23, 11:21

  20. Benni Mack voted on patch set 5 V +2 CR +2 02/23/23, 14:21

  21. Benni Mack merged patch set 6 02/23/23, 14:21