Review main Merged

77893[BUGFIX] Respect HTTP method restrictions for modules

Oli Bartsch CR +2 V +2 Normal +66 −29 updated 02/22/23, 10:22

Commit message

Defined HTTP methods in module configurations are
now properly added to the corresponding routes.

Previously they were just passed as route options, which
however does not work as the HTTP method is an own
property of Route.

Additionally, the site configurations' sub module "delete"
is now always called via POST, as defined in the module
configuration.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 912

  1. Oli Bartsch uploaded patch set 1 02/17/23, 16:26

  2. core-ci voted on patch set 1 V +1 02/17/23, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37846

  3. Oli Bartsch uploaded patch set 2 V +1 02/22/23, 08:17

  4. core-ci voted on patch set 2 V +1 02/22/23, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37955

  5. Jochen Roth voted on patch set 2 V +1 CR +1 02/22/23, 09:00

  6. Oli Bartsch uploaded patch set 3 CR +1 V +1 02/22/23, 09:41

  7. core-ci voted on patch set 3 V +1 02/22/23, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37961

  8. Jochen Roth voted on patch set 3 V +1 CR +1 02/22/23, 09:56

  9. Benni Mack voted on patch set 3 V +1 CR +1 02/22/23, 10:02

  10. Andreas Kienast voted on patch set 3 V +1 CR +1 02/22/23, 10:06

  11. Oli Bartsch voted on patch set 3 V +2 CR +2 02/22/23, 10:22

  12. Oli Bartsch merged patch set 4 02/22/23, 10:22