Review main Merged

77897[BUGFIX] Use `Set()` instead of custom array unique implementation

Andreas Kienast CR +2 V +2 Easy +2 −11 updated 02/20/23, 11:49

Commit message

JavaScript has a native Set() object that ensures uniqueness of values
by design and is therefore faster than any custom uniqueness
implementation.

The Install Tool had an obvious implementation that is superseded by
`Set()`, being several milliseconds faster, depending on the client's
CPU.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Torben Hansen +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Torben Hansen +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Andreas Kienast uploaded patch set 1 02/19/23, 12:40

  2. Oliver Klee updated the commit message in patch set 2 02/19/23, 12:47

  3. core-ci voted on patch set 1 V -1 02/19/23, 12:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37873

  4. Andreas Kienast uploaded patch set 3 02/19/23, 13:02

  5. Andreas Kienast uploaded patch set 4 02/19/23, 13:03

  6. core-ci voted on patch set 4 V +1 02/19/23, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37876

  7. Nikita Hovratov voted on patch set 4 V +1 CR +1 02/19/23, 15:50

  8. Torben Hansen voted on patch set 4 V +1 CR +1 02/19/23, 18:03

  9. Oli Bartsch voted on patch set 4 V +2 CR +2 02/20/23, 11:49

  10. Oli Bartsch merged patch set 5 02/20/23, 11:49