77898[BUGFIX] Fix PHP 8 warning in LinkValidatorController
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Stefan Bürk +2
- Anja Leichsenring +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/linkvalidator/Classes/Linktype/AbstractLinktype.php+1 −0
- typo3/sysext/linkvalidator/Classes/Linktype/ExternalLinktype.php4+5 −0
- typo3/sysext/linkvalidator/Classes/Linktype/FileLinktype.php+1 −0
- typo3/sysext/linkvalidator/Classes/Linktype/InternalLinktype.php+7 −2
- typo3/sysext/linkvalidator/Classes/Linktype/LinktypeInterface.php+2 −0
- typo3/sysext/linkvalidator/Classes/Repository/BrokenLinkRepository.php7+11 −3
- typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php3+1 −1
Review log 4457
Show 2432 earlier messages
-
Thomas Hohn uploaded patch set 1 02/20/23, 09:50
-
core-ci voted on patch set 1 V +1 02/20/23, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37887
-
Oliver Klee updated the commit message in patch set 2
V +102/20/23, 10:30 -
Oliver Klee voted on patch set 2 CR +1 02/20/23, 10:30
-
core-ci voted on patch set 2 V +1 02/20/23, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37889
-
Guido Schmechel voted on patch set 2 CR +1 02/20/23, 13:31
-
Sybille Peters commented on patch set 2 02/20/23, 16:40
-
Thomas Hohn uploaded patch set 3
CR +1V +102/20/23, 17:21 -
Thomas Hohn commented on patch set 2 02/20/23, 17:21
ExternalLinktype.php:249ReplyWould make sense ;-) -
core-ci voted on patch set 3 V +1 02/20/23, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37904
-
Oliver Klee voted on patch set 3 CR +1 02/20/23, 17:32
-
Sybille Peters commented on patch set 3 CR -1 02/26/23, 15:28
ExternalLinktype.php:255You don't need to assign $errorType it twice. -
Sybille Peters rebased onto patch set 4
CR +1V +102/26/23, 15:32 -
Sybille Peters commented on patch set 4 02/26/23, 15:34
ExternalLinktype.php:255ReplyDone -
core-ci voted on patch set 4 V +1 02/26/23, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38120
-
Sybille Peters commented on patch set 4 V +1 CR +1 02/26/23, 15:47
I can't reproduce the exception (without the patch in latest main) but the change makes sense nonetheless -
JAKOTA Design Group GmbH commented on patch set 4 02/26/23, 19:15
BrokenLinkRepository.php:318Wouldn't is be better to initialise $errorParams as [] instead of null and adding a null check later? And if $errorParams can be null shouldn't the type be ?array ? -
Sybille Peters commented on patch set 4 V 0 CR -1 02/26/23, 19:18
BrokenLinkRepository.php:318ReplyI agree, it would be better to initialize as array. It is a bit of a mess currently. Please also look at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77777 where there are similar changes. -
Sybille Peters uploaded patch set 5
CR -1V +102/26/23, 20:08 -
Sybille Peters commented on patch set 5 02/26/23, 20:09
BrokenLinkRepository.php:318ReplyDone -
core-ci voted on patch set 5 V -1 02/26/23, 20:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38132
-
Thomas Hohn uploaded patch set 6
V -102/27/23, 05:12 -
Thomas Hohn commented on patch set 6 02/27/23, 05:32
BrokenLinkRepository.php:318ReplyBut it's a breaking change to change the signature of the method (it's even a public method) - I believe you should add a comment that the method signature should change in v13? -
Thomas Hohn uploaded patch set 7 02/27/23, 05:40
-
core-ci voted on patch set 6 V -1 02/27/23, 05:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38140
-
core-ci voted on patch set 7 V +1 02/27/23, 05:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38141
-
JAKOTA Design Group GmbH commented on patch set 7 02/27/23, 11:09
LinkAnalyzer.php:228Is this a code style thing? Why not just add the null/false check in the function call? $this->brokenLinkRepository->addBrokenLink($record, false, $hookObj->getErrorParams() ?: []); -
Thomas Hohn commented on patch set 7 02/27/23, 11:23
LinkAnalyzer.php:228ReplyYou could ;-) -
Thomas Hohn uploaded patch set 8
V +102/27/23, 11:27 -
Thomas Hohn commented on patch set 7 02/27/23, 11:27
LinkAnalyzer.php:228ReplyDone -
Oliver Klee commented on patch set 8 02/27/23, 11:30
BrokenLinkRepository.php:321The type here is missing: @param array $record -
core-ci voted on patch set 8 V +1 02/27/23, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38150
-
Thomas Hohn uploaded patch set 9
V +102/27/23, 11:46 -
Thomas Hohn commented on patch set 8 02/27/23, 11:46
BrokenLinkRepository.php:318ReplyDoneBrokenLinkRepository.php:321ReplyDone -
core-ci voted on patch set 9 V +1 02/27/23, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38152
-
Thomas Hohn rebased onto patch set 10
V +103/06/23, 05:41 -
core-ci voted on patch set 10 V +1 03/06/23, 05:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38512
-
Benni Mack voted on patch set 10 CR +1 03/07/23, 08:06
-
Jörg Bösche voted on patch set 10 CR +1 03/10/23, 07:41
-
Oliver Klee voted on patch set 10 CR +1 03/10/23, 10:21
-
Jochen Roth voted on patch set 10 V +1 CR +1 03/16/23, 15:36
-
Guido Schmechel voted on patch set 10 CR +1 03/21/23, 08:27
-
Thomas Hohn rebased onto patch set 11
CR +1V +104/11/23, 18:45The following files contain Git conflicts: * typo3/sysext/linkvalidator/Classes/Linktype/ExternalLinktype.php -
core-ci voted on patch set 11 V -1 04/11/23, 19:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40475
-
Thomas Hohn uploaded patch set 12
V -104/19/23, 07:03 -
Thomas Hohn marked it ready for review 04/19/23, 07:03
-
core-ci voted on patch set 12 V +1 04/19/23, 07:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40892
-
Oliver Klee voted on patch set 12 CR +1 04/19/23, 07:24
-
Jörg Bösche voted on patch set 12 CR +1 04/19/23, 12:50
-
Benni Mack voted on patch set 12 V +1 CR +1 04/20/23, 09:04
-
Anja Leichsenring commented on patch set 12 V -1 04/20/23, 09:26
on it -
Anja Leichsenring uploaded patch set 13
CR +1V +104/20/23, 09:32 -
Anja Leichsenring voted on patch set 13 V +1 CR +1 04/20/23, 09:33
-
core-ci voted on patch set 13 V +1 04/20/23, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40949
-
Oliver Klee voted on patch set 13 CR +1 04/20/23, 10:01
-
Stefan Bürk voted on patch set 13 V +2 CR +2 04/24/23, 16:08
-
Stefan Bürk merged patch set 14 04/24/23, 16:08
ExternalLinktype.php:249