77899[BUGFIX] Typo3DbQueryParser allows records with no child
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Thomas Hohn +1
- Markus Klein +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Markus Klein +1
Issues 1
Files 4
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+28 −27
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/blogs.csv+1 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/QueryParserTest.php2+17 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/WorkspaceTest.php+4 −3
Review log 3348
Show 1323 earlier messages
-
Harald Witt uploaded patch set 1 02/20/23, 09:55
-
core-ci voted on patch set 1 V -1 02/20/23, 10:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37888
-
Harald Witt commented on patch set 2
V -102/21/23, 15:00Published edit on patch set 1. -
core-ci voted on patch set 2 V +1 02/21/23, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37931
-
Markus Klein uploaded patch set 3
V +102/23/23, 12:23 -
core-ci voted on patch set 3 V +1 02/23/23, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38014
-
Markus Klein uploaded patch set 4
V +102/23/23, 12:40 -
core-ci voted on patch set 4 V -1 02/23/23, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38015
-
Markus Klein uploaded patch set 5
V -102/23/23, 14:46 -
core-ci voted on patch set 5 V -1 02/23/23, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38025
-
Markus Klein uploaded patch set 6
V -102/23/23, 18:43 -
core-ci voted on patch set 6 V -1 02/23/23, 19:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38032
-
Markus Klein uploaded patch set 7
V -102/24/23, 13:53 -
Markus Klein commented on patch set 7 CR -1 02/24/23, 13:55
-1 vote until @Harald has finished his local testing -
core-ci voted on patch set 7 V +1 02/24/23, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38055
-
Harald Witt uploaded patch set 8
CR -1V +103/30/23, 17:32 -
Harald Witt uploaded patch set 9 03/30/23, 17:52
-
core-ci voted on patch set 8 V -1 03/30/23, 17:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39876
-
core-ci voted on patch set 9 V -1 03/30/23, 18:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39877
-
Harald Witt uploaded patch set 10
V -103/30/23, 19:02 -
core-ci voted on patch set 10 V +1 03/30/23, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39886
-
Oliver Klee commented on patch set 10 03/30/23, 20:03
Can we cover this with a regression test? -
Markus Klein commented on patch set 10 03/31/23, 08:46
Did you remove my tests from set 7 on purpose in the last revisions?
-
Markus Klein uploaded patch set 11
V +103/31/23, 09:11 -
Markus Klein commented on patch set 11 03/31/23, 09:13
Reply
Done -
core-ci voted on patch set 11 V -1 03/31/23, 09:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39897
-
Markus Klein uploaded patch set 12
V -103/31/23, 09:27 -
Oliver Klee uploaded patch set 13 03/31/23, 09:29
-
core-ci voted on patch set 12 V +1 03/31/23, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39898
-
core-ci voted on patch set 13 V +1 03/31/23, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39899
-
Markus Klein voted on patch set 13 V +1 CR +1 04/25/23, 13:21
-
Oliver Klee voted on patch set 13 V +1 04/25/23, 13:47
-
Markus Klein uploaded patch set 14
CR +1V +105/02/23, 12:52 -
core-ci voted on patch set 14 V +1 05/02/23, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41352
-
Oliver Klee voted on patch set 14 V +1 05/02/23, 13:17
-
Markus Klein voted on patch set 14 V +1 CR +1 05/02/23, 13:36
-
Thomas Hohn commented on patch set 14 05/02/23, 14:00
QueryParserTest.php:180Missing /** * @test */ ? -
Markus Klein uploaded patch set 15
CR +1V +105/02/23, 14:06 -
Markus Klein commented on patch set 14 V +1 CR +1 05/02/23, 14:06
QueryParserTest.php:180Replygnaaa.... thx good finding. I guess that was a rebase mistake -
core-ci voted on patch set 15 V +1 05/02/23, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41356
-
Oliver Klee voted on patch set 15 V +1 05/02/23, 14:16
-
Thomas Hohn voted on patch set 15 CR +1 05/02/23, 14:16
-
Benni Mack updated the commit message in patch set 16
CR +1V +105/03/23, 09:50 -
Markus Klein voted on patch set 16 V +1 CR +1 05/03/23, 13:09
-
Thomas Hohn voted on patch set 16 CR +1 05/24/23, 05:56
-
Oliver Klee voted on patch set 16 V +1 05/24/23, 07:37
-
Georg Ringer voted on patch set 16 V +2 CR +2 05/25/23, 07:22
-
Georg Ringer merged patch set 17 05/25/23, 07:22