Review main Merged

77899[BUGFIX] Typo3DbQueryParser allows records with no child

Harald Witt CR +2 V +2 Normal +50 −30 updated 05/25/23, 07:22

Commit message

Typo3DbQueryParser ignored records with no child records in some cases.

This is mitigated by adding a correct WHERE condition
for the match-field/parent evaluation.

This effects TCA relations with
MM_match_fields, foreign_match_fields or foreign_table_field.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Thomas Hohn +1
    • Markus Klein +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Markus Klein +1

Issues 1

Files 4

Review log 3348

Show 1323 earlier messages
  1. Harald Witt uploaded patch set 1 02/20/23, 09:55

  2. core-ci voted on patch set 1 V -1 02/20/23, 10:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37888

  3. Harald Witt commented on patch set 2 V -1 02/21/23, 15:00

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 02/21/23, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37931

  5. Markus Klein uploaded patch set 3 V +1 02/23/23, 12:23

  6. core-ci voted on patch set 3 V +1 02/23/23, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38014

  7. Markus Klein uploaded patch set 4 V +1 02/23/23, 12:40

  8. core-ci voted on patch set 4 V -1 02/23/23, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38015

  9. Markus Klein uploaded patch set 5 V -1 02/23/23, 14:46

  10. core-ci voted on patch set 5 V -1 02/23/23, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38025

  11. Markus Klein uploaded patch set 6 V -1 02/23/23, 18:43

  12. core-ci voted on patch set 6 V -1 02/23/23, 19:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38032

  13. Markus Klein uploaded patch set 7 V -1 02/24/23, 13:53

  14. Markus Klein commented on patch set 7 CR -1 02/24/23, 13:55

    -1 vote until @Harald has finished his local testing
  15. core-ci voted on patch set 7 V +1 02/24/23, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38055

  16. Harald Witt uploaded patch set 8 CR -1 V +1 03/30/23, 17:32

  17. Harald Witt uploaded patch set 9 03/30/23, 17:52

  18. core-ci voted on patch set 8 V -1 03/30/23, 17:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39876

  19. core-ci voted on patch set 9 V -1 03/30/23, 18:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39877

  20. Harald Witt uploaded patch set 10 V -1 03/30/23, 19:02

  21. core-ci voted on patch set 10 V +1 03/30/23, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39886

  22. Oliver Klee commented on patch set 10 03/30/23, 20:03

    Can we cover this with a regression test?
  23. Markus Klein commented on patch set 10 03/31/23, 08:46

    Did you remove my tests from set 7 on purpose in the last revisions?
  1. Markus Klein uploaded patch set 11 V +1 03/31/23, 09:11

  2. Markus Klein commented on patch set 11 03/31/23, 09:13

    Reply

    Done
  3. core-ci voted on patch set 11 V -1 03/31/23, 09:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39897

  4. Markus Klein uploaded patch set 12 V -1 03/31/23, 09:27

  5. Oliver Klee uploaded patch set 13 03/31/23, 09:29

  6. core-ci voted on patch set 12 V +1 03/31/23, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39898

  7. core-ci voted on patch set 13 V +1 03/31/23, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39899

  8. Markus Klein voted on patch set 13 V +1 CR +1 04/25/23, 13:21

  9. Oliver Klee voted on patch set 13 V +1 04/25/23, 13:47

  10. Markus Klein uploaded patch set 14 CR +1 V +1 05/02/23, 12:52

  11. core-ci voted on patch set 14 V +1 05/02/23, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41352

  12. Oliver Klee voted on patch set 14 V +1 05/02/23, 13:17

  13. Markus Klein voted on patch set 14 V +1 CR +1 05/02/23, 13:36

  14. Thomas Hohn commented on patch set 14 05/02/23, 14:00

    QueryParserTest.php:180

    Missing /** * @test */ ?
  15. Markus Klein uploaded patch set 15 CR +1 V +1 05/02/23, 14:06

  16. Markus Klein commented on patch set 14 V +1 CR +1 05/02/23, 14:06

    QueryParserTest.php:180 Reply

    gnaaa.... thx good finding. I guess that was a rebase mistake
  17. core-ci voted on patch set 15 V +1 05/02/23, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41356

  18. Oliver Klee voted on patch set 15 V +1 05/02/23, 14:16

  19. Thomas Hohn voted on patch set 15 CR +1 05/02/23, 14:16

  20. Benni Mack updated the commit message in patch set 16 CR +1 V +1 05/03/23, 09:50

  21. Markus Klein voted on patch set 16 V +1 CR +1 05/03/23, 13:09

  22. Thomas Hohn voted on patch set 16 CR +1 05/24/23, 05:56

  23. Oliver Klee voted on patch set 16 V +1 05/24/23, 07:37

  24. Georg Ringer voted on patch set 16 V +2 CR +2 05/25/23, 07:22

  25. Georg Ringer merged patch set 17 05/25/23, 07:22