Review 11.5 Merged

77901[BUGFIX] Use `Set()` instead of custom array unique implementation

Oli Bartsch CR +2 V +2 Easy +2 −11 updated 02/20/23, 12:47

Commit message

JavaScript has a native Set() object that ensures uniqueness of values
by design and is therefore faster than any custom uniqueness
implementation.

The Install Tool had an obvious implementation that is superseded by
`Set()`, being several milliseconds faster, depending on the client's
CPU.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Oli Bartsch uploaded patch set 1 02/20/23, 11:52

  2. core-ci voted on patch set 1 V +1 02/20/23, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37892

  3. Oli Bartsch voted on patch set 1 V +2 CR +2 02/20/23, 12:46

  4. Oli Bartsch merged patch set 2 02/20/23, 12:47