77904[BUGFIX] Fix PHP 8 warning in TypoScriptFrontendController
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1620
-
Thomas Hohn uploaded patch set 1 02/20/23, 14:56
-
Thomas Hohn updated the commit message in patch set 2 02/20/23, 14:57
-
core-ci voted on patch set 2 V +1 02/20/23, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37900
-
core-ci voted on patch set 1 V +1 02/20/23, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37899
-
Oliver Klee commented on patch set 2 02/24/23, 17:29
Is main not affected? -
Thomas Hohn commented on patch set 2 02/24/23, 17:34
Reply
Hi - no - it has been completely rewritten in main -
Oliver Klee voted on patch set 2 CR +1 02/24/23, 17:42
-
Stefan Bürk updated the commit message in patch set 3
CR +1V +102/24/23, 22:39 -
Stefan Bürk voted on patch set 3 V +1 CR +1 02/24/23, 22:44
-
core-ci voted on patch set 3 V +1 02/24/23, 22:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38072
-
Guido Schmechel voted on patch set 3 CR +1 02/25/23, 13:36
-
Oliver Klee voted on patch set 3 CR +1 02/26/23, 21:27
-
Oli Bartsch commented on patch set 3 02/27/23, 11:24
TypoScriptFrontendController.php:1267According to the class properties @var annotation, should we fallback to int or string (preferentially "int")? -
Thomas Hohn commented on patch set 3 02/27/23, 11:32
TypoScriptFrontendController.php:1267ReplyYes would propably be better just to return 0 then -
Thomas Hohn uploaded patch set 4
CR +1V +102/27/23, 11:55 -
Thomas Hohn commented on patch set 4 02/27/23, 11:55
TypoScriptFrontendController.php:1267ReplyDone -
core-ci voted on patch set 4 V +1 02/27/23, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38153
-
Christian Kuhn voted on patch set 4 V +1 CR +1 02/27/23, 13:57
-
Stefan Bürk voted on patch set 4 V +2 CR +2 02/27/23, 19:29
-
Stefan Bürk merged patch set 5 02/27/23, 19:29