Review main Merged

77920[BUGFIX] Ensure complete image is shown in image manipulation editor

Jasmina Ließmann CR +2 V +2 Easy +6 −1 updated 03/02/23, 19:07

Commit message

In viewports with a resolution of less than 1000px, portrait format
images are not fully visible in the image manipulation editor.
This adjustment ensures that the complete image is visible.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Josef Glatz +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Josef Glatz +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Jasmina Ließmann uploaded patch set 1 02/21/23, 21:03

  2. core-ci voted on patch set 1 V +1 02/21/23, 21:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37943

  3. Jasmina Ließmann uploaded patch set 2 V +1 02/27/23, 20:51

  4. core-ci voted on patch set 2 V +1 02/27/23, 20:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38175

  5. Josef Glatz commented on patch set 2 V +1 CR +1 02/28/23, 05:53

    Looks good and it works for me. Also tested on an iPhone in landscape orientation
  6. Christian Kuhn commented on patch set 2 V +1 CR +1 03/01/23, 13:25

    I tend to say that's fine: I'm not 100% sure for "pixel exact cropping" when the image is scaled, but since this as rather a regression from v10, I tend to accept the patch. Pushed the v11 version as well, and clicked around on it as well, which looks good to me, too. Any further thoughts / tests?
  7. Stefan Bürk commented on patch set 2 V +1 CR +1 03/02/23, 19:01

    Reply

    I played arround with the behaviour in v10, the v11 state with and without this patch. Honestly, the current v11 state is not good. Having the image scaled and eventually not that "pixel-perfect" selection is better than not beeing possible to crop an area outside the visible area. Therefore, I would say that this patches reverts a "regression" to a state which is better understandable. An additional fix regarding "pixel-perfection" should be investigated in a dedicated patch.
  8. Stefan Bürk voted on patch set 2 V +2 CR +2 03/02/23, 19:06

  9. Stefan Bürk merged patch set 3 03/02/23, 19:07