Review main Merged

77924[BUGFIX] Fix PHP Warning in GraphicalFunctions

Thomas Hohn CR +2 V +2 Easy +1 −1 updated 02/24/23, 11:32

Commit message

In the method getWordPairsForLineBreak, there is a missing
coalescing operator around $wordsArray[$index + 1].
In the last iteration for uneven values of $wordsCount it
will be undefined.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Markus Klein +1
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Markus Klein +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Thomas Hohn uploaded patch set 1 02/22/23, 06:49

  2. core-ci voted on patch set 1 V +1 02/22/23, 06:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37954

  3. Oliver Hader voted on patch set 1 CR +1 02/22/23, 10:34

  4. Oliver Klee voted on patch set 1 CR +1 02/22/23, 10:40

  5. Stefan Bürk voted on patch set 1 CR +1 02/23/23, 11:42

  6. Benni Mack voted on patch set 1 V +1 CR +1 02/23/23, 21:29

  7. Markus Klein voted on patch set 1 V +1 CR +1 02/23/23, 21:54

  8. Stefan Bürk voted on patch set 1 V +2 CR +2 02/24/23, 11:32

  9. Stefan Bürk merged patch set 2 02/24/23, 11:32