77926[BUGFIX] Defer requests to LiveSearch
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Stefan Bürk +1
-
Verified V +2 Done
- Oliver Hader +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1923
-
Andreas Kienast uploaded patch set 1 02/22/23, 09:33
-
core-ci voted on patch set 1 V +1 02/22/23, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37959
-
Oli Bartsch commented on patch set 1 02/22/23, 16:14
Not quite sure if this qualifies for a priority bugfix. -
Andreas Kienast commented on patch set 1 02/23/23, 07:50
Reply
I'd say, it qualifies at least as it minimizes the number of useless requests sent to the server. -
Stefan Bürk commented on patch set 1 02/23/23, 11:37
Reply
Opt for drop the 10.4 also. Not a priority/security bugfix. -
Andreas Kienast updated the commit message in patch set 2
V +102/23/23, 11:39 -
Andreas Kienast commented on patch set 2 02/23/23, 11:40
Reply
Done -
core-ci voted on patch set 2 V +1 02/23/23, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38011
-
Oliver Hader commented on patch set 2 02/23/23, 12:32
Reply
I think it's totally fine to fix this issue in v10.4, since it reduces the load on the server-system when having multiple users being active in the backend at the same time. -
Oliver Hader commented on patch set 2 02/23/23, 12:37
Reply
When looking to recent changes in TYPO3 v10.4 (https://github.com/TYPO3/typo3/commits/10.4), lots of them should have been omitted, since they were not important or security related. It's difficult to apply a strict rule on this - for instance I assess this like "does it fix a bug?", "does it help users?" and "are the chances low that this would introduce new problems?". And for this particular change-set here, I'd answer all three questions with "yes". -
Oliver Hader updated the commit message in patch set 3
V +103/07/23, 17:41 -
Oliver Hader voted on patch set 3 CR +1 03/07/23, 17:41
-
Oliver Hader commented on patch set 3 03/07/23, 17:42
Reply
Done -
Oliver Hader voted on patch set 3 V +1 03/07/23, 17:49
-
Stefan Bürk voted on patch set 3 CR +1 03/07/23, 17:53
-
Stefan Bürk voted on patch set 3 V +1 03/07/23, 17:59
-
core-ci voted on patch set 3 V -1 03/07/23, 18:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38620
-
Oliver Hader rebased onto patch set 4
CR +1V +103/07/23, 20:55 -
Oliver Hader voted on patch set 4 V +1 CR +1 03/07/23, 20:55
-
core-ci voted on patch set 4 V +1 03/07/23, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38629
-
Stefan Bürk voted on patch set 4 V +1 CR +1 03/08/23, 18:12
-
Oliver Hader voted on patch set 4 V +2 CR +2 03/08/23, 18:14
-
Oliver Hader merged patch set 5 03/08/23, 18:14