Review main Merged

77929[TASK] Optimize I/O for configuration migration detection

Markus Klein CR +2 V +2 Easy +18 −14 updated 02/23/23, 21:02

Commit message

Move the file_exists checks around to execute
those only if really needed.

The bootstrap methods are executed whenever
the Core does any action, so its footprint should
be as slim as possible.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1014

  1. Markus Klein uploaded patch set 1 02/22/23, 12:40

  2. Markus Klein updated the commit message in patch set 2 02/22/23, 12:43

  3. Stefan Bürk commented on patch set 2 02/22/23, 12:50

    Bootstrap.php:239

    Due the concatination of the deprecation notes to here .. can we emphasize that from here up to the end of the method is deprecatted and can be removed (replaced with return false) in v14 ?
  4. core-ci voted on patch set 2 V +1 02/22/23, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37971

  5. core-ci voted on patch set 1 V +1 02/22/23, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37970

  6. Markus Klein commented on patch set 3 V +1 02/22/23, 14:08

    Published edit on patch set 2.
  7. Markus Klein commented on patch set 3 02/22/23, 14:08

    Bootstrap.php:239 Reply

    Done
  8. Markus Klein commented on patch set 4 02/22/23, 14:09

    Published edit on patch set 3.
  9. core-ci voted on patch set 3 V -1 02/22/23, 14:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37975

  10. core-ci voted on patch set 4 V +1 02/22/23, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37976

  11. Stefan Bürk voted on patch set 4 V +1 CR +1 02/23/23, 08:24

  12. Oli Bartsch voted on patch set 4 V +1 CR +1 02/23/23, 20:03

  13. Benni Mack voted on patch set 4 V +2 CR +2 02/23/23, 21:02

  14. Benni Mack merged patch set 5 02/23/23, 21:02