Review main Merged

77931[FEATURE] Allow resources to be moved/copied with drag and drop in filelist

Benjamin Kott CR +2 V +2 Expert +735 −526 updated 02/25/23, 17:18

Commit message

This patch enables drag-and-drop for resources within the file list.
It is now possible to transfer files and folders with drag operations to
folders visible in the current view.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 32

Show 12 more files

Review log 2032

Show 47 earlier messages
  1. Benjamin Kott uploaded patch set 1 02/22/23, 15:40

  2. core-ci voted on patch set 1 V -1 02/22/23, 16:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37981

  3. Benjamin Kott uploaded patch set 2 V -1 02/23/23, 10:00

  4. core-ci voted on patch set 2 V -1 02/23/23, 10:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37998

  5. Benjamin Kott uploaded patch set 3 V -1 02/23/23, 14:47

  6. core-ci voted on patch set 3 V -1 02/23/23, 15:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38026

  7. Benjamin Kott uploaded patch set 4 V -1 02/23/23, 15:56

  1. core-ci voted on patch set 4 V -1 02/23/23, 16:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38028

  2. Benjamin Kott uploaded patch set 5 V -1 02/24/23, 08:29

  3. core-ci voted on patch set 5 V -1 02/24/23, 08:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38040

  4. Benjamin Kott uploaded patch set 6 V -1 02/24/23, 10:30

  5. core-ci voted on patch set 6 V -1 02/24/23, 10:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38044

  6. Benjamin Kott uploaded patch set 7 V -1 02/24/23, 14:09

  7. Benjamin Kott updated the commit message in patch set 8 02/24/23, 14:30

  8. core-ci voted on patch set 7 V +1 02/24/23, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38056

  9. core-ci voted on patch set 8 V +1 02/24/23, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38059

  10. Benjamin Kott uploaded patch set 9 V +1 02/24/23, 14:48

  11. Benni Mack uploaded patch set 10 02/24/23, 15:06

  12. Benni Mack voted on patch set 10 V +1 CR +1 02/24/23, 15:07

  13. core-ci voted on patch set 9 V +1 02/24/23, 15:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38060

  14. core-ci voted on patch set 10 V +1 02/24/23, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38061

  15. Frank Nägler commented on patch set 8 02/24/23, 15:25

    file-storage-tree-container.ts:32

    maybe obsolete?
  16. Frank Nägler voted on patch set 10 V +1 02/24/23, 15:25

  17. Andreas Kienast commented on patch set 10 CR -1 02/25/23, 13:56

    on it

    file-list-dragdrop.ts:33

    Arrr ;)

    file-list-dragdrop.ts:77

    Argument is unused

    file-list-dragdrop.ts:123

    Argument is unused
  18. Andreas Kienast uploaded patch set 11 CR +1 V +1 02/25/23, 14:02

  19. Andreas Kienast commented on patch set 11 V -1 02/25/23, 14:03

    Everytime I start a drag from the filelist, I see a white rectangle flickering at the top left corner.

    file-storage-tree-container.ts:32 Reply

    Done

    file-list-dragdrop.ts:33 Reply

    Done

    file-list-dragdrop.ts:77 Reply

    Done

    file-list-dragdrop.ts:123 Reply

    Done
  20. core-ci voted on patch set 11 V +1 02/25/23, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38096

  21. Andreas Kienast uploaded patch set 12 V +1 02/25/23, 14:45

  22. Andreas Kienast voted on patch set 12 V +1 CR +1 02/25/23, 14:45

  23. core-ci voted on patch set 12 V +1 02/25/23, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38097

  24. Benni Mack voted on patch set 12 V +2 CR +2 02/25/23, 17:18

  25. Benni Mack merged patch set 13 02/25/23, 17:18